On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day <[email protected]> wrote: > > On Tue, 6 Apr 2021, Bruce Ashfield wrote: > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <[email protected]> > > wrote: > > > > > > > > > this doesn't look right, but i don't know how one wants to resolve > > > it: > > > > > > > What part doesn't look right ? I don't see any issues with it. > > > > Bruce > > > > > FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:" > > isn't the colon on the wrong end?
In a quick scan of other layers, they are all leaving the variable in the same state (with a trailing colon), whether they are using _prepend or _append. So while it does count on the existing variable to end with a colon, that seems to be no different than other places. I quickly dumped the environment for an openvswitch build and the default FILESEXTRAPATHS does end with a colon, so it should be safe. Whether it is perfect form or not, I can't say, since I've never looked at that in detail either. But I very well could be missing something! (I haven't had a coffee yet). Bruce > > rday -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6313): https://lists.yoctoproject.org/g/meta-virtualization/message/6313 Mute This Topic: https://lists.yoctoproject.org/mt/81885752/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
