On Fri, 9 Apr 2021, Richard Purdie wrote: > On Fri, 2021-04-09 at 06:38 -0400, Robert P. J. Day wrote: > > On Fri, 9 Apr 2021, Richard Purdie wrote: > > > > > On Fri, 2021-04-09 at 10:04 +0000, Peter Kjellerstedt wrote: > > > > > -----Original Message----- > > > > > From: [email protected] <meta- > > > > > [email protected]> On Behalf Of Richard Purdie > > > > > Sent: den 6 april 2021 15:59 > > > > > To: Bruce Ashfield <[email protected]>; Robert P. J. Day > > > > > <[email protected]> > > > > > Cc: [email protected] > > > > > Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in > > > > > openvswitch_git.bb > > > > > > > > > > On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote: > > > > > > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day > > > > > > <[email protected]> > > > > > wrote: > > > > > > > > > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote: > > > > > > > > > > > > > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote: > > > > > > > > > > > > > > > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > this doesn't look right, but i don't know how one wants > > > > > > > > > > > to > > > > > resolve > > > > > > > > > > > it: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > What part doesn't look right ? I don't see any issues with > > > > > > > > > > it. > > > > > > > > > > > > > > > > > > > > Bruce > > > > > > > > > > > > > > > > > > > > > FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:" > > > > > > > > > > > > > > > > > > isn't the colon on the wrong end? > > > > > > > > > > > > > > > > In a quick scan of other layers, they are all leaving the > > > > > > > > variable > > > > > in > > > > > > > > the same state (with a trailing colon), whether they are using > > > > > > > > _prepend or _append. > > > > > > > > > > > > > > i beg to differ -- here's a single example: > > > > > > > > > > > > > > meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb: > > > > > > > FILESEXTRAPATHS_append = > > > > > > > ":${COREBASE}/meta/recipes-core/zlib/zlib" > > > > > > > > > > > > Do a build with that. You have a double colon, so you found a bad > > > > > > example, unless the double colon is expected. > > > > > > > > > > > > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib" > > > > > > > > > > Anything using append should be adding a leading colon, anything > > > > > prepending should be adding a trailing one. > > > > > > > > > > I suspect we need an audit and cleanup of several layers... > > > > > > > > > > Cheers, > > > > > > > > > > Richard > > > > > > > > Normally, I would agree with you. However, the definition of > > > > FILESEXTRAPATHS in > > > > meta/conf/bitbake.conf contradicts that: > > > > > > > > FILESEXTRAPATHS ?= "__default:" > > > > > > > > The benefit of that (I guess) is that the added string looks the same > > > > whether > > > > _prepend or _append is used. At the same time it is a bit confusing > > > > since > > > > this is not the normal pattern for adding to a colon-separated variable. > > > > > > It gets worse unfortunately. See the code in classes/utils.bbclass which > > > handles this and the magic __default: value :/. > > > > > > It is far from clear what is going on :( > > > > well, now that i've released the ferret into the henhouse, i see my > > work here is done. :-) > > Great, we've found some issues but the real challenge is figuring > out how to improve things and move forward from here. If you really > want to help, the work is just started. > > If all these unresolved threads you're leaving are "someone else's > problem", that effectively means you're just creating work for > others and I know that personally, I have a ton already but thanks > for adding to the queue.
i'm more than happy to submit patches, after i've verified that i actually understand the problem and someone else verifies that there *is* a problem. patches forthcoming. rday
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6331): https://lists.yoctoproject.org/g/meta-virtualization/message/6331 Mute This Topic: https://lists.yoctoproject.org/mt/81885752/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
