I agree with the changes. But please fix the style stuff (whitespaces, 80 characters, ...)

So the flip_detection is currently not working for two reasons:
1. We need a stored parameter for opt-in (most cams don't need it).
2. Every cam that needs flip_detection must have hvflip support.
   Since we have no decoders in the driver we can only do that in the
   hardware.

to 1. The kernel-module paramter actually already exists. It just isn't stored anywhere. And quite frankly I can't think of a decent place for it.

to 2. I think that's already there for the concerned cams. Just checking required.

GWater


Vasily Khoruzhick schrieb:
On 25 November 2008 23:26:06 GWater wrote:
And again my patches.
Now without fake hardware auto-exposure for ov9650 sensors.
And partly nicer commit messages.

GWater

Vasily Khoruzhick schrieb:
On 25 November 2008 23:01:41 GWater wrote:
software auto-exposure can only be realised for ov965x anyway. Most
other sensors don't provide the necessary data or already have
hardware-autoexposure.

I disagree about libv4l. userspace does not have access to the device.
But that is vital for Vasily's patches.

Remember that Vasily's patches don't manipulate the image stream we get
from the device - they rather make the device give us a brighter or
darker image stream.

GWater
What about ov76xx sensors? They have YAVG register too

Here's some patches from my side :)

0009 - I've added one parameter to the sn9c20x_write_i2c_data function, because I need to specify last byte of i2c-write sequence. It should be set to 0x1e in changing exposure value sequence. Without it I have image freezes during exposure decres

0010 - Use sn9c20x_write_i2c_data_ext in ov_set_exposure
0011 - Some fixes mentioned before :)

Regards
Vasily


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to