Saturation is supposed to change the intensity of a color so this patch is not right as well, Also while hue is supposed to change the actual color this is wrong for that as well since it should not wash the entire image in a particular color like this patch does.
I've uploaded for reference an archive containing two data files for both saturation and hue plus a ruby ruby script that can feed values from one of the data sources through the debugfs to show a gradual progression of changing colors. The data values i use for hue and saturation come from the values used under windows. Run this file using the following command, where <datafile> is wither hues.yaml or sats.yaml # ruby ./color.rb <datafile> link: http://groups.google.com/group/microdia/web/color_ref.tar.gz My understanding of how the bridge handles hue and saturation is that you are basically modifying the coefficients for the bridges color matrix. The color matrix is the set of coefficients used to convert the RGB data provided by the sensor ot YUV color-space. Saturation should just be a matter of proper scaling of the matrix values, with hue involving rotating the values using sin and cos functions. The bridge appears to use two bytes per value with the second as far as i can tell either 0 or f which likly is used tell the sign of the first byte. Since both saturation and hue, as well as contrast and brightness, play with the values of our color matrix there should really be just one function that modifies things based on all those values so as to avoid overwriting what a previous function has done. Still since we have yet to get a working version of saturation i still very much suggest for the time being we revert the current saturation code and just apply a new patch when someone gets an acceptable patch for this. On Mon, Mar 16, 2009 at 5:00 PM, Stefan Krastanov <[email protected]> wrote: > Should not color change be related to Hue and not to Saturation? > > 2009/3/16 Stefan Krastanov <[email protected]> >> >> Hi, >> Reporting about 0C45:6270 with MT9V011 Sensor. >> Now I am having b/w only at sat=0. >> For every other value I am having absolutely violet or green (on rare >> occasions red) picture. >> It's circling from violet to green on every 10 to 20 integer steps. >> Testing done with mplayer and v4l2ucp. The format was yuv420 if this is of >> any importance. >> Attaching screenshoot. It's the whole desktop - sorry, I'm in a hurry and >> "take screenshoot-current window" is not working for some reason. >> >> Regards >> Stefan >> >> 2009/3/16 Josua Grawitter <[email protected]> >>> >>> Am Montag 16 März 2009 17:44:45 schrieb Brian Johnson: >>> > You posted a patch for this? i haven't seen one show up in my mail box. >>> > >>> Here it is. It fixes some problems (especially the one which causes all >>> values >>> < 255 to be b/w. (the function still right-shifted the value by 8 bits. >>> Bad.) >>> >>> Unfortunatly there seem to be some more issues. Please test. >>> >>> GWater >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
