[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433319 ] Trustin Lee commented on DIRMINA-162: -------------------------------------
Your patch is great generally, but needs subtle improvement: 1. We have to decide where to put get/setSessionTracker(). I thought puting it in IoServiceConfig level would be better. If this is right, we will need ConnectionlessIoServiceConfig interface. 2. We also need to be notified when a user calls IoSession.close() to prevent memory leak. 3. Connectionless is just too loooooong. Wouldn't there be any better name? > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Priority: Minor > Attachments: mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
