[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433331 ] Greg Duffy commented on DIRMINA-162: ------------------------------------
I did reply on this issue page, it's a few comments above, I guess I fooled you with my '>' marks :) 1. OK, I did not notice that method on IoSession when I checked. That is great! 2. I agree, since IoSession.close() is MINA's method anyway, we should integrate 'sessionClosed(IoSession)' into the interface. Users will still want to add an 'early' filter (probably right after ThreadPoolFilter) to detect things like BYE messages that close sessions, though (I think). 3. IoSessionRecycler is a very nice name. I agree, IoServiceConfig is the right place. Do you also want to allow this optional session recycling for transports with connections? What do you think about the read buffer size issue I mentioned before? > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Priority: Minor > Fix For: 1.0 > > Attachments: mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
