[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433327 ] Trustin Lee commented on DIRMINA-162: -------------------------------------
Oops, Greg replied to the JIRA notification. You had to visit the issue page and write a comment there to keep consistency. :) I will paste it for you this time. >Your patch is great generally, but needs subtle improvement: Thanks! I expected as much, it is just a first stab. >1. We have to decide where to put get/setSessionTracker(). I thought puting it >in IoServiceConfig level would be better. If this is right, we will need >ConnectionlessIoServiceConfig interface. I also initally thought this, but could not figure out how to access the current IoServiceConfig from the relevant areas in DatagramAcceptor/Connector(Delegate) without some major refactoring ... maybe you can provide some hints on that... >2. We also need to be notified when a user calls IoSession.close() to prevent >memory leak. I initially thought this could be left up to a filter (similarly, some protocols may implement certain messages (like a bye message) that can close a session), but it does seem like a good thing to go ahead and integrate into the interface. >3. Connectionless is just too loooooong. Wouldn't there be any better name? Hehe .. but isn't that what Java is about? :) Well, how about just SessionTracker? Perhaps there are even protocols out there whose sessions span TCP connections? Maybe this would be great as an optional behavior for any IO service. .>I think this issue should be fixed in 1.0. That would be awesome! > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Priority: Minor > Fix For: 1.0 > > Attachments: mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
