Le 2012-01-31 01:57, JonY a écrit :
> On 1/31/2012 11:07, Rafaël Carré wrote:
>> ---
>> mingw-w64-headers/configure.ac | 19 +++++++++++--------
>> 1 files changed, 11 insertions(+), 8 deletions(-)
>>
>
> What is the benefit of it being split up?
Kai wanted to split up at list IDL to keep it disabled.
> If possible keep the options
> as is, just enable them by default, eg --enable-sdks=all by default.
I think --enable-sdks="ddk,directx" is a strange way to use configure.
--disable-foo --enable-bar is the standard way to use autoconf, and this
makes the configure.ac code smaller.
./configure --help says:
Optional Features:
--disable-FEATURE do not include FEATURE (same as
--enable-FEATURE=no)
--enable-FEATURE[=ARG] include FEATURE [ARG=yes]
Attached patch applies on top of first patch and just change the
default, but I still prefer those other ones (separate --enable-ddk /
--enable-directx)
>From f70bf5c0156714407b0cae171eb8d8031eecc7cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafa=C3=ABl=20Carr=C3=A9?= <[email protected]>
Date: Tue, 31 Jan 2012 21:07:51 -0500
Subject: [PATCH] Enable DDK and directx headers by default
---
mingw-w64-headers/configure.ac | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mingw-w64-headers/configure.ac b/mingw-w64-headers/configure.ac
index 7afa861..683a7a0 100644
--- a/mingw-w64-headers/configure.ac
+++ b/mingw-w64-headers/configure.ac
@@ -78,9 +78,9 @@ enable_ddk=no
AC_MSG_CHECKING([for optional sdk headers])
AC_ARG_ENABLE([sdk],
[AS_HELP_STRING([--enable-sdk=ARG],
- [Add the desired SDK, where ARG can be one of ddk, directx or all])],
+ [Add the desired SDK, where ARG can be one of ddk, directx or no])],
[],
- [enable_sdk=no])
+ [enable_sdk=all])
AS_CASE([$enable_sdk],
[all|yes],[
enable_sdk="ddk,directx"
@@ -91,7 +91,7 @@ AS_CASE([$enable_sdk],
[directx],[
enable_directx=yes],
[no],[],
- [AC_MSG_ERROR([Invalid option: $enable_sdk. Please choose one of ddk, directx or all.])])
+ [AC_MSG_ERROR([Invalid option: $enable_sdk. Please choose one of ddk, directx, no or all.])])
AC_MSG_RESULT([$enable_sdk])
AS_VAR_IF([enable_directx],[yes],[
--
1.7.8.3
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
