Le 2012-02-01 05:43, JonY a écrit :
> On 2/1/2012 10:12, Rafaël Carré wrote:
>> Le 2012-01-31 01:57, JonY a écrit :
>>> On 1/31/2012 11:07, Rafaël Carré wrote:
>>>> ---
>>>>  mingw-w64-headers/configure.ac |   19 +++++++++++--------
>>>>  1 files changed, 11 insertions(+), 8 deletions(-)
>>>>
>>>
>>> What is the benefit of it being split up? 
>>
>> Kai wanted to split up at list IDL to keep it disabled.
>>
> 
> OK, sure. IDL regen looks unrelated to installing additional headers.
> 
>>> If possible keep the options
>>> as is, just enable them by default, eg --enable-sdks=all by default.
>>
>> I think --enable-sdks="ddk,directx" is a strange way to use configure.
>>
>> --disable-foo --enable-bar is the standard way to use autoconf, and this
>> makes the configure.ac code smaller.
>>
>> ./configure --help says:
>>
>> Optional Features:
>>
>>   --disable-FEATURE       do not include FEATURE (same as
>> --enable-FEATURE=no)
>>   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
>>
>>
>> Attached patch applies on top of first patch and just change the
>> default, but I still prefer those other ones (separate --enable-ddk /
>> --enable-directx)
>>
>>
> 
> IMHO, keep the "all" in the AS_HELP_STRING output, since it is a valid
> argument.

I kept it and committed the change in r4792 after Kai gave me SVN access.

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to