Jacek Caban schreef op ma 22-07-2013 om 11:50 [+0200]:
> On 07/21/13 23:24, dw wrote:
> >> Attached is the patch I came up with to fix the build issue.
> > You are checking for defined(__MINGW64_VERSION_MAJOR).  Would it make 
> > sense to do (__MINGW64_VERSION_MAJOR >= 3)?
> 
> IMO, if the change works with older mingw-w64 release, not checking
> version is better. If it doesn't, then yeah, something like that may be
> needed.

All my tests were done against trunk snapshots (so major version 3). I
could add such a conditional, but what benefit would it have? The
mingw-w64 v1 branch also has an intrin.h with declarations for the
Interlocked symbols, so the current patch should work just fine on the
v1 branch.

Regards,

Erik



------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to