On 8/15/2016 4:54 AM, Martin Storsjö wrote:
but 30 of these would be a huge hassle for the approvers as well.
Not really, if they are well contained with an explanation matching it
close by, it's trivial to review.
Historically my experiences haven't been good in this area. But if you
are prepared to review them, I guess I can make them.
============= Missing prototypes =============
clog10.c, clog10f.c, clog10l.c:
- The prototypes for the functions created in these files are
protected by #ifdef _GNU_SOURCE. Since we should always build
the .c file, we need to add the define so we can find the
prototype.
gai_strerrorA.c:
- wcstombs() is in stdlib.
abs64.c:
- llabs() is in stdlib.h.
_vscprintf_p.c, _vscwprintf_p.c, _vswprintf_p.c:
- _vscprintf_p_l, _vscwprintf_p_l & _vswprintf_p_l prototypes are
protected by #if. Add the define so we can find them.
Sure
Attached. Ok to push?
dw
diff --git a/mingw-w64-crt/complex/clog10.c b/mingw-w64-crt/complex/clog10.c
index f8545cd..8553e00 100644
--- a/mingw-w64-crt/complex/clog10.c
+++ b/mingw-w64-crt/complex/clog10.c
@@ -44,5 +44,6 @@
/* double version of the functions. */
#define _NEW_COMPLEX_DOUBLE 1
+#define _GNU_SOURCE
#include "complex_internal.h"
#include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10f.c b/mingw-w64-crt/complex/clog10f.c
index 36ac497..8ce97d3 100644
--- a/mingw-w64-crt/complex/clog10f.c
+++ b/mingw-w64-crt/complex/clog10f.c
@@ -44,5 +44,6 @@
/* Float version of the functions. */
#define _NEW_COMPLEX_FLOAT 1
+#define _GNU_SOURCE
#include "complex_internal.h"
#include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10l.c b/mingw-w64-crt/complex/clog10l.c
index 8baa2aa..11d85c7 100644
--- a/mingw-w64-crt/complex/clog10l.c
+++ b/mingw-w64-crt/complex/clog10l.c
@@ -44,5 +44,6 @@
/* long double version of the functions. */
#define _NEW_COMPLEX_LDOUBLE 1
+#define _GNU_SOURCE
#include "complex_internal.h"
#include "clog10.def.h"
diff --git a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
index ebdc06a..9023f93 100644
--- a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
+++ b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
@@ -3,6 +3,7 @@
#endif
#undef __CRT__NO_INLINE
#define __CRT__NO_INLINE
+#include <stdlib.h>
#include <winsock2.h>
#include <ws2tcpip.h>
diff --git a/mingw-w64-crt/math/abs64.c b/mingw-w64-crt/math/abs64.c
index 693f909..3f2133a 100644
--- a/mingw-w64-crt/math/abs64.c
+++ b/mingw-w64-crt/math/abs64.c
@@ -1,4 +1,5 @@
#include <intrin.h>
+#include <stdlib.h>
__MINGW_EXTENSION __int64 __cdecl _abs64(__int64 x) {
return llabs(x);
diff --git a/mingw-w64-crt/secapi/_vscprintf_p.c
b/mingw-w64-crt/secapi/_vscprintf_p.c
index 42365b3..c007199 100644
--- a/mingw-w64-crt/secapi/_vscprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscprintf_p.c
@@ -1,4 +1,9 @@
+/**
+ * This file is part of the mingw-w64 runtime package.
+ * No warranty is given; refer to the file DISCLAIMER within this package.
+ */
#define _vscprintf_p SAVE__vscprintf_p
+#define MINGW_HAS_SECURE_API 1
#include <stdio.h>
#undef _vscprintf_p
diff --git a/mingw-w64-crt/secapi/_vscwprintf_p.c
b/mingw-w64-crt/secapi/_vscwprintf_p.c
index 7baa5bd..aad5c8d 100644
--- a/mingw-w64-crt/secapi/_vscwprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscwprintf_p.c
@@ -1,4 +1,9 @@
+/**
+ * This file is part of the mingw-w64 runtime package.
+ * No warranty is given; refer to the file DISCLAIMER within this package.
+ */
#define _vscwprintf_p SAVE__vscwprintf_p
+#define MINGW_HAS_SECURE_API 1
#include <stdio.h>
#undef _vscwprintf_p
diff --git a/mingw-w64-crt/secapi/_vswprintf_p.c
b/mingw-w64-crt/secapi/_vswprintf_p.c
index eb10c59..2bf582a 100644
--- a/mingw-w64-crt/secapi/_vswprintf_p.c
+++ b/mingw-w64-crt/secapi/_vswprintf_p.c
@@ -1,4 +1,9 @@
+/**
+ * This file is part of the mingw-w64 runtime package.
+ * No warranty is given; refer to the file DISCLAIMER within this package.
+ */
#define _vswprintf_p SAVE__vswprintf_p
+#define MINGW_HAS_SECURE_API 1
#include <stdio.h>
#undef _vswprintf_p
------------------------------------------------------------------------------
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
