Hi, thanks for taking care about those warnings. Interesting that the redefinition is also triggered by whitespace changes, and leading zeros ... but well, I guess it is related to partial parsing, and by comparing for this diagnostic on not unified token stream.
From my POV patch is ok. My personal preference is to get rid of leading zeros, but well, I am fine. Regards, Kai 2016-08-16 8:45 GMT+02:00 Martin Storsjö <mar...@martin.st>: > On Mon, 15 Aug 2016, dw wrote: > >> On 8/15/2016 4:54 AM, Martin Storsjö wrote: >>>> >>>> but 30 of these would be a huge hassle for the approvers as well. >>> >>> Not really, if they are well contained with an explanation matching it >>> close by, it's trivial to review. >> >> >> Historically my experiences haven't been good in this area. But if you >> are prepared to review them, I guess I can make them. >> >>>> ============= Missing prototypes ============= >>>> clog10.c, clog10f.c, clog10l.c: >>>> - The prototypes for the functions created in these files are >>>> protected by #ifdef _GNU_SOURCE. Since we should always build >>>> the .c file, we need to add the define so we can find the >>>> prototype. >>>> gai_strerrorA.c: >>>> - wcstombs() is in stdlib. >>>> abs64.c: >>>> - llabs() is in stdlib.h. >>>> _vscprintf_p.c, _vscwprintf_p.c, _vswprintf_p.c: >>>> - _vscprintf_p_l, _vscwprintf_p_l & _vswprintf_p_l prototypes are >>>> protected by #if. Add the define so we can find them. >>> >>> Sure >> >> >> Attached. Ok to push? > > > Remove the extra copyright disclaimer headers that you're adding. If you're > keen on adding them, send a separate patch for that. > > No other objection from me, but please wait for at least somebody else to > comment on it as well. > > // Martin > ------------------------------------------------------------------------------ > > _______________________________________________ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
