On 2017/5/2 3:08, David Grayson wrote: > Oops, I should have learned my lesson. Well, here it is again. I think my > original email 6 days ago was good though. I did see the patch and we had a discussion on irc. That attribute seemed to have been removed for a reason, which otherwise caused errors.
```plaintext [23:04:42] <ktietz> jacek ping [23:07:02] <ktietz> do you recall why we removed that selectany from GUID definitions? I remember we did together some time ago, but I can't recall it right [23:08:33] <ktietz> as we have a suggestion in ML thread "[Mingw-w64-public] [PATCH] guiddef.h: Use __declspec(selectany) on GUID declarations."" about adding it [23:22:17] <lh_mouse> try `git blame` ? [23:22:30] <lh_mouse> maybe you can find the commit that removed it. [23:24:43] <ktietz> AFAIR this happened already on svn ... in general I have to admit that annotation of declspec(selectany) is the right thing, but we had some reason for not doing it. [23:25:31] <ktietz> scenario I could think about is, that op code defines its own guids without selectany, which would then collide with that one with selectany ``` -- Best regards, LH_Mouse ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
