Ok, thanks for trying to get the reasoning, why we didn't marked it as selectany. So I think it is time to add this selectany to our master, and see if we get really any issues reported for it. The only scenario I am concerned about is user-defined, library defined. As prototypes are changing, and it might be that gcc sees selectany to some extend as ABI-relevant and errors out.
Regards, Kai 2017-05-02 7:57 GMT+02:00 Liu Hao <[email protected]>: > On 2017/5/2 12:04, David Grayson wrote: >> Thanks for the info. >> >> I used "git blame" on guiddef.h and it looks like the logic has been the >> same since 2007. I don't see any sign that Kai removed the >> DECLSPEC_SELECTANY from the GUID declarations, as far as I know it was just >> always missing. >> >> So the code has been the same for 10 years, but then two people have >> complained about it on the mailing list in the last week. Perhaps there >> was a change in GCC that made it start ignoring certain attributes on >> variable definitions if the attributes were not present on the declaration. >> >> Tomay: are you able to apply my patch, rebuild your mingw-w64 libraries, >> and see if it fixes your issue? If you can't do that, could you tell me >> what the steps are to reproduce your issue so I can see whether the patch >> helps? >> >> Will the patch get merged if I try to reproduce the problem Kai mentioned >> about having a GUID collision and I fail to reproduce it? > Again, I am considering about removing duplicate definitions of > UUIDs/GUIDs as the 'real' resolution. But before doing that I _have to_ > understand why those duplicates have been there. > > > -- > Best regards, > LH_Mouse > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
