-------- Forwarded Message --------
Subject: Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in
specstrings.h.
Date: Wed, 10 May 2017 08:24:25 -0700
From: David Grayson <[email protected]>
To: Liu Hao <[email protected]>
OK, thanks. I've attached a new patch where the #include is after the
__cplusplus stuff.
I also included a second patch that will add an include guard for
specstrings.h, since Microsoft seems to do that too.
driverspecs.h is also missing an include guard but it is part of the
React DDK so I didn't want to mess around with editing at the moment.
--David
On Tue, May 9, 2017 at 9:07 PM, Liu Hao <[email protected]
<mailto:[email protected]>> wrote:
On 2017/5/10 10:34, David Grayson wrote:
This patch adds "#include <driverspecs.h>" near the end of
specstrings.h,
because the same is done in Microsoft's version of
specstrings.h. With
this patch, I am able to build Microsoft's devcon utility without
modification. Thanks!
You must `#include` that header AFTER the `#ifdef __cplusplus ...
#endif` block.
Anyway, this header seems short of a header guard. I shall ask
someone for sure.
-- Best regards,
LH_Mouse
From bb87ae14e5a381617d1969837efd0d9c3ddefa25 Mon Sep 17 00:00:00 2001
From: David Grayson <[email protected]>
Date: Tue, 9 May 2017 09:15:29 -0700
Subject: [PATCH 1/2] specstrings.h: Include driverspecs.h near the bottom.
That's what the Microsoft header does, and their devcon utility
depends on it.
---
mingw-w64-headers/include/specstrings.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mingw-w64-headers/include/specstrings.h
b/mingw-w64-headers/include/specstrings.h
index 485b4330..984dd64b 100644
--- a/mingw-w64-headers/include/specstrings.h
+++ b/mingw-w64-headers/include/specstrings.h
@@ -328,3 +328,5 @@ extern "C" {
#ifdef __cplusplus
}
#endif
+
+#include <driverspecs.h>
--
2.12.1
From 65c70e8cad7d6c234b00a4d3240a98cae49465e7 Mon Sep 17 00:00:00 2001
From: David Grayson <[email protected]>
Date: Wed, 10 May 2017 07:07:04 -0700
Subject: [PATCH 2/2] specstrings.h: Add an include guard.
---
mingw-w64-headers/include/specstrings.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mingw-w64-headers/include/specstrings.h
b/mingw-w64-headers/include/specstrings.h
index 984dd64b..bcb9fc3c 100644
--- a/mingw-w64-headers/include/specstrings.h
+++ b/mingw-w64-headers/include/specstrings.h
@@ -3,6 +3,10 @@
* This file is part of the mingw-w64 runtime package.
* No warranty is given; refer to the file DISCLAIMER.PD within this package.
*/
+
+#ifndef SPECSTRINGS_H
+#define SPECSTRINGS_H
+
#define __specstrings
#include <sal.h>
@@ -330,3 +334,5 @@ extern "C" {
#endif
#include <driverspecs.h>
+
+#endif
--
2.12.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
