Yeah, sorry, I only sent those patches to LH by mistake. Yes, I purposely used the same include guard name as Microsoft.
--David On Wed, May 10, 2017 at 8:55 AM, Liu Hao <[email protected]> wrote: > > > > -------- Forwarded Message -------- > Subject: Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in > specstrings.h. > Date: Wed, 10 May 2017 08:24:25 -0700 > From: David Grayson <[email protected]> > To: Liu Hao <[email protected]> > > > > OK, thanks. I've attached a new patch where the #include is after the > __cplusplus stuff. > > I also included a second patch that will add an include guard for > specstrings.h, since Microsoft seems to do that too. > > driverspecs.h is also missing an include guard but it is part of the React > DDK so I didn't want to mess around with editing at the moment. > > --David > > On Tue, May 9, 2017 at 9:07 PM, Liu Hao <[email protected] <mailto: > [email protected]>> wrote: > > On 2017/5/10 10:34, David Grayson wrote: > > This patch adds "#include <driverspecs.h>" near the end of > specstrings.h, > because the same is done in Microsoft's version of > specstrings.h. With > this patch, I am able to build Microsoft's devcon utility without > modification. Thanks! > > You must `#include` that header AFTER the `#ifdef __cplusplus ... > #endif` block. > > Anyway, this header seems short of a header guard. I shall ask > someone for sure. > > -- Best regards, > LH_Mouse > > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
