On Fri, 3 Jul 2026, Martin Storsjö wrote:
On Fri, 3 Jul 2026, Pali Rohár wrote:
On Friday 03 July 2026 01:00:15 Martin Storsjö wrote:
On Sun, 28 Jun 2026, Pali Rohár wrote:
Evgeny, you bring this issue for arm64 and I have prepared a fix which
is in the attachment of the previous email. Could you please check and
test it? I really need feeback from your configuration / setup of
toolchain to know if it address your issue. Because I do not have it.
Martin, if you have a time, could you do (code) review for first two
changes which are for amd64 (which is rewriting / replacing the
__mingw_init_ehandler implementation)?
Those patches feel like super overkill.
I don't think we should have code to construct SEH unwind code by hand
here.
I really can't see why we should need to do that.
For example, it is needed for C signal handlers.
Were C signal handlers working for a non-SEH build on x86_64 before your
patches? If yes, then fix it by making it work like it did before. If not,
then we don't need to fix it.
We do not want that patch of yours to fix something that someone might not
even care about.
For the aarch64 non-SEH case that Evgeny was asking about; before your
changes it didn't have any toplevel SEH handler at all, I would guess. And
I guess that signal handlers don't work at all, if that's what the toplvel
SEH handler is used for.
That's fine - one can do a million different perfectly usable programs
without a signal handler, the vast majority of programs don't use one.
As the non-SEH build mode isn't meant as a permanent build mode, I don't
think we should spend code on trying to fix signal handlers for it.
Just remove the #error and let it work as it did before.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
