Hi Edward,

i agree the wording was a bit awkward, so i have committed a tweaked
version of your patch:

 - Make it clearer which "installation" we are talking about,
   there is text between the description of "make fake" and
   this paragraph, and people could otherwise confuse this
   with "make install"

 - I don't think "done" is better than "complete",
   and i don't think sub-directory is clearer than "directory".
   The document also talks about "the directory patches"
   in another paragraph.

 - As noticed by others, "template" would be misleading.

Yours,
  Ingo


Edward wrote on Fri, Jul 25, 2014 at 04:29:03PM +0800:

> Hi,
> 
> The original wording doesn't seems to flow too well:
> 
> "Create pkg/PLIST. After the install is complete use the developer's
> command, make plist which makes the file PLIST in the pkg directory.
> This file is a candidate packing list."
> 
> I would like to suggest changing to the followig:
> 
> "Create pkg/PLIST. After the installation is done, use the developer's
> command make plist, which creates the file PLIST in pkg sub-directory.
> It will be a template for this port."
> 
> The patch to my suggestion is at the bottom of this mail, ok?
> 
> Regards,
> Edward.
> 
> Index: guide.html
> ===================================================================
> RCS file: /cvs/www/faq/ports/guide.html,v
> retrieving revision 1.29
> diff -u -p -r1.29 guide.html
> --- guide.html        21 Jun 2014 12:17:47 -0000      1.29
> +++ guide.html        25 Jul 2014 08:08:35 -0000
> @@ -498,10 +498,9 @@ generated packing-lists). Remember that 
>  For automatic updating of <tt>/etc</tt>, sysmerge(8) may help.
>  <br><br><li>
>  Create <tt>pkg/PLIST</tt>.
> -After the install is complete use the developer's command,
> -<tt><b>make plist</b></tt> which makes the file <tt>PLIST</tt> in the
> -<tt>pkg</tt> directory.
> -This file is a candidate packing list.
> +After the installation is done, use the developer's command 
> +<tt><b>make plist</b></tt>, which creates the file <tt>PLIST</tt> in 
> +<tt>pkg</tt> sub-directory. It will be a template for this port.
>  <p>
>  Peruse <tt>PLIST</tt> and verify that everything was installed and that it 
> was
>  installed in the proper locations.

Reply via email to