Hi Martin, I'm trying to decide if/when these patches should get committed, so it'd be a great help if you could answer my questions below:
On Thu, 2008-07-03 at 19:57 +0200, Martin Sakmar wrote: > Hi everybody, > > I attached some patches, which contain changes I made to my working > copy. > Here are short descriptions: > > vumeter_bitblt.patch: > * added peak hold function to VU meters and separate VU meters for > left and right channels > * replaced all "bitBlt" with drawPixmap from QPainter and also removed > pixmaps used for double buffering in paintEvent. They're not needed, > because from Qt 4.0 QWidget automatically double-buffers its painting > * transparent background for labels if BgColor is not set in skin > * added installEventFilter to TrackTableView and ComboBox in > mixxxview.cpp, so keyboard shortcuts will work when they have focus. > This probably fixes bug #217557 How does this behave when you have the track table selected? How do you "deselect" the track table? What about when the search box is selected? I've seen another application deal with this problem by making the equivalent of the track table lose focus when you hit escape, which allows the shortcut keys to work again. (The bitBlt fixes look great though!) > * enginebuffercue.cpp: cue goto and stop only when key is pressed not > released > This looks OK, shouldn't affect CDJ-style cueing. > outlineskin.patch: > * VU meters with peak hold in outline skin and also master vu meter is > changed to stereo > splashscreen.patch: > * enables splash screen on startup > * used splash.png from src and modified SConscript to install it > What are peoples' thoughts on splash screens? Our start-up time sucks, but personally I'm not in favour of a splash screen. > defs.patch: > * changed READCHUNK_NO from 40 to 80 to get better waveform view > I'm not sure if this one is good, but at least you can try it. > Maybe RJ can comment on this? Will this #define even be used when we switch to the new waveform view? Thanks, Albert > Cheers, > Martin > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > _______________________________________________ Mixxx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
