Hey Ryan, Thanks!
I really like the idea of linking it up to the new search stuff - makes perfect sense really - and that way the "active" part of "active filter" is just that its listening to the currentDeckPlaying event. As for UI stuff - I'll have a play around, I've never been much of a UI developer so I'll do what I can. I would like to get my code reviewed before attempting to hack into the existing views though. Who would you suggest I contact for that? Should I be writing tests? If so, is there any docs to get me started? I'm forked off trunk btw - some one mentioned the history feature! In fact that's affecting my search results because played tracks always appear in the results. thanks keith On 21 March 2012 18:27, RJ Ryan <russelljr...@gmail.com> wrote: > Hey Keith, > > Nice work! I like your idea of making this possible to do in any view. I > think there are two main problems you should figure out how to solve if > you're going to follow up on that: > > 1) How to make the checkboxes visible in any library-table-view, but hidable > so they don't waste vertical real-estate. > > Maybe a tiny down-arrow button at the top right of the library that when > clicked will slide the "filter panel" down? > > Maybe you could even experiment with totally changing the library layout. > Take the search box out of the top-left of the library and instead make a > search icon (again maybe hovering at the top-right?) that when clicked > rolls-down the search box and your filter checkboxes. It sounds like some > fun stuff to experiment with. > > 2) When you click a checkbox (again, thinking about showing the checkboxes > in any library view), I think it should simply append search query terms to > your current search query using some of the work by Bart Verstrynge on > advanced search operators as a jumping off point. > > For example -- if you click "similar BPM", it should append "~bpm" to your > search box, which is the advanced search operator for "similar BPM to the > currently loaded tracks". And if you cilck "similar Key" it should just > append "~key" to your search. This has the added benefit of educating users > on how to use the advanced search operators. > > Are you basing your work off of trunk or the 1.10 branch? There is a fancy > new session history feature in trunk. :) > > RJ > > On Wed, Mar 21, 2012 at 8:25 PM, keithsalisb...@gmail.com > <keithsalisb...@gmail.com> wrote: >> >> Hi Yves, >> >> > Another thing that comes to my mind is to display tracks (on top of the >> > list?) that you've played often in combination with the currently >> > playing track. But I'm not sure if you have that kind of information in >> > mixxx. >> >> That's something that might fit into what I have in mind for my next >> little contribution - a "history" view - because apparently the data >> is being stored somewhere, so its only fair to let the user have >> access to us and be able to use it - for example to create playlists - >> or crates. >> >> By the way, my branch is quite stable now, so if you want to give it a >> try and provide some feedback that would be great! >> >> bzr branch lp:~keithsalisbury/mixxx/track_selector_feature >> >> While on the subject, does anyone know the procedure for proposing a >> merge - I'm not there quite yet, but would be good to know. Do i need >> to write some tests? Does the code need to be reviewed by someone? ie, >> someone who knows C++!! lol There's probably some questionable design >> patterns in my code - not least that my model is binding itself to the >> view!!! (I thought that was the job of the controller!) >> >> cheers >> Keith >> >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > -- keithsalisb...@gmail.com ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
