Crap, I didn't include the patch. :-)
________________________________
From: Steven Boswell II <ulat...@yahoo.com>
To: mixxx-devel <mixxx-devel@lists.sourceforge.net>
Sent: Saturday, April 20, 2013 6:37 PM
Subject: [Mixxx-devel] Bug fixes for Mixxx
I just successfully DJed a car show using the Mixxx 1.11.0 prerelease! No
major problems!
Enclosed are some fixes for bugs I encountered while working on various
features. TreeItem::insertChildren() was always adding children at index 0,
instead of the requested position. SidebarModel::parent() would try to use a
null internal-pointer; this could happen is a tree-item is deleted. And I
found that CrateFeature::slotImportPlaylist() was really inefficient; it was
doing a database commit after every imported track in a crate. It's still
doing a database query for each imported track, to see if it's already in the
database, but I haven't looked into fixing that yet.
As usual, my patches are against the 1.11.0 release branch.
There was one nasty problem I encountered today that I couldn't work
around...Mixxx doesn't seem to have any daytime skins! All the skins I tried
were nearly impossible to see in daylight, even though I was in the shade. I
don't mind working on some daytime skins, I was just wondering why there don't
seem to be any.
Steven Boswell
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
--- mixxx/src/library/sidebarmodel.cpp 2013-04-07 19:41:28.496946000 -0700
+++ mixxx-build/src/library/sidebarmodel.cpp 2013-04-20 17:55:14.416148183 -0700
@@ -100,6 +100,8 @@
return QModelIndex();
} else {
TreeItem* tree_item = (TreeItem*)index.internalPointer();
+ if (tree_item == NULL)
+ return QModelIndex();
TreeItem* tree_item_parent = tree_item->parent();
// if we have selected an item at the first level of a childnode
--- mixxx/src/library/treeitem.cpp 2013-04-07 19:41:28.496946000 -0700
+++ mixxx-build/src/library/treeitem.cpp 2013-04-20 17:55:14.417148310 -0700
@@ -101,7 +101,7 @@
for (int row = 0; row < count; ++row) {
TreeItem* item = data.at(row);
- m_childItems.insert(row, item);
+ m_childItems.insert(position + row, item);
}
return true;
--- mixxx/src/library/cratefeature.cpp 2013-04-07 19:41:28.496946000 -0700
+++ mixxx-build/src/library/cratefeature.cpp 2013-04-20 17:55:14.415148056 -0700
@@ -476,10 +503,7 @@
//qDebug() << "Size of Imported Playlist: " << entries.size();
//Iterate over the List that holds URLs of playlist entires
- for (int i = 0; i < entries.size(); ++i) {
- m_crateTableModel.addTrack(QModelIndex(), entries[i]);
- //qDebug() << "Playlist entry: " << entries[i];
- }
+ m_crateTableModel.addTracks (QModelIndex(), entries);
//delete the parser object
if(playlist_parser)
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
