>We need a bug report to track those changes. So please file one, assign it to
>you and add your patch. The status should be "In Progress"
Sigh...formality :-)
>@RJ: What is the state of the 1.11.0 branch. It is still open for
patches like this?
I sure hope it is...I'm still finding bugs :-)
Enclosed is a patch to CrateDAO::addTracksToCrate(). Without it, if one
imports to a crate, and (for example) all of the tracks are already in that
crate, it'll only think half of them failed to add.
BTW, I'm working on a big performance improvement to importing crates. It uses
SQL queries to avoid adding tracks that are already in the track_locations
table, and does the same for the crate_tracks table. I hope to submit it for
your consideration shortly.
Steven Boswell--- mixxx/src/library/dao/cratedao.cpp 2013-04-07 19:41:28.496946000 -0700
+++ mixxx-build/src/library/dao/cratedao.cpp 2013-04-21 09:29:29.822356551 -0700
@@ -231,6 +231,7 @@
// We must emit only those trackID that were added so we need to
// remove the failed ones.
trackIdList.removeAt(i);
+ --i;
}
}
transaction.commit();
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
