I'm generally in agreement. However, I'm not sure if mapping should automatically detect if a 4 band EQ is loaded and react accordingly. Users may get confused if they pick a 4 band EQ and then their filter knob isn't filtering. I think mappings should make it an explicit option that the user must consciously choose. This will make it a bit more involved to set up (pick 4 band EQ in EQ preferences, then select controller option), but the explicitness makes it clear what is going on.
On 01/16/2017 11:15 AM, RJ Ryan wrote: > I'm still strongly against this idea (we discussed it pre-2.0). It won't > work if we ever decide to move the quick effect unit somewhere other > than below the EQs (including user designed skins that don't follow this > convention). (worse, it will restrict us to position quick effects below > and gain above from a backwards compatibility perspective). > > A skin can provide a skin-specific "preference" option, like Deere > offers with its tweaks menu. But a skin can do whatever it wants (hide > the quick effect knob when a 4-band EQ is present, shrink them so they > all fit, etc.) anyway. > > A controller can already MIDI learn the 4th EQ knob -- so a user who > wants to change their gain or filter knob (or whatever else their > manufacturer happened to put in a place that makes sense) to a 4th EQ > band can do it in a few clicks. > > Controller scripts can already do things like detect when 4 knobs are > available, and repurpose the filter knob automatically. > > Preference options should be reserved for options that work in all > situations (any controller script, any skin). > > On Mon, Jan 16, 2017 at 7:05 AM Be <b...@gmx.com <mailto:b...@gmx.com>> > wrote: > > Maybe we shouldn't add any hacks to the EQ preferences and leave it to > controller mappings considering that this will only affect controllers. > This will be more user friendly when we have a better way for users to > edit mapping options without opening a JavaScript file in a text editor. > > On 01/16/2017 08:57 AM, Be wrote: > > Setting the gain knob to the 4th EQ knob would be odd because the gain > > knob is typically above EQs. So, to use a 4 band EQ by repurposing a > > gain knob, it would make more sense to remap the gain + EQ knobs > so they > > go in order down the controller. I don't think an option should be > added > > to the EQ preferences for this. > > > > On the other hand, filter knobs are typically below EQs, so I think > > adding an option in the EQ preferences to use the QuickEffect knob as > > the 4th EQ knob could work well. This option should only appear when a > > 4-band EQ is loaded. > > > > On 01/16/2017 08:24 AM, Daniel Schürmann wrote: > >> As said, you can already build a sink with a dynamic amount of knobs. > >> But you cannot do this on a controller. > >> > >> I personally would use the gain knob. (My controller has no > filter knob) > >> > >> Using a four band EQ on a controller with only 3 knobs does not > really > >> makes sense. So the user needs to "solve" the issue there as well. > >> Currently he can "learn" the new EQ knobs, but it would be really > handy > >> to have a checkbox or something in the EQ preferences to "user the > >> filter knob for EQ" or use "gain knob for EQ" > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> 2017-01-16 13:47 GMT+01:00 Ferran Pujol Camins > >> <ferranpujolcam...@gmail.com <mailto:ferranpujolcam...@gmail.com> > <mailto:ferranpujolcam...@gmail.com > <mailto:ferranpujolcam...@gmail.com>>>: > >> > >> Following discussion in > https://github.com/mixxxdj/mixxx/pull/1007 > >> <https://github.com/mixxxdj/mixxx/pull/1007> > >> > >> Reusing the Qick effect knob for the fourth EQ band, Is > IMO very > >> handy > >> because it works for the Controller and for the GUI. The GUI > >> still matches 1:1 to the controller. > >> > >> We have also discussed to use the gain knob as fourth EQ > band. > >> If we consider that, we need to decouple the > GUI/Controller form > >> the Internal CO values from the engine and allow to set a > >> mapping form the EQ preferences. > >> > >> I prefer this over scripting solution, since it will be "midi > >> leanable" and it do not requires to touch all mappings, > except > >> changing the names to the new mappable knobs. > >> > >> But you loose either the gain knob or the Quick Effect knob. > I want > >> both of them :) > >> > >> IMHO shrinking the knobs so they fit in the same space when > n=4 is > >> possible. Again, Traktor does it. > >> > >> Suppose that the 4 knobs can satisfactorily be fit in each skin. > >> Wouldn't you prefer this over loosing gain or Quick Effect knob? > >> > >> > >> > >> > > ------------------------------------------------------------------------------ > >> Developer Access Program for Intel Xeon Phi Processors > >> Access to Intel Xeon Phi processor-based developer platforms. > >> With one year of Intel Parallel Studio XE. > >> Training and support from Colfax. > >> Order your platform today. http://sdm.link/xeonphi > >> _______________________________________________ > >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today > >> http://mixxx.org > >> > >> > >> Mixxx-devel mailing list > >> Mixxx-devel@lists.sourceforge.net > <mailto:Mixxx-devel@lists.sourceforge.net> > >> <mailto:Mixxx-devel@lists.sourceforge.net > <mailto:Mixxx-devel@lists.sourceforge.net>> > >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > >> <https://lists.sourceforge.net/lists/listinfo/mixxx-devel> > >> > >> > >> > >> > >> > > ------------------------------------------------------------------------------ > >> Developer Access Program for Intel Xeon Phi Processors > >> Access to Intel Xeon Phi processor-based developer platforms. > >> With one year of Intel Parallel Studio XE. > >> Training and support from Colfax. > >> Order your platform today. http://sdm.link/xeonphi > >> > >> > >> > >> _______________________________________________ > >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today > >> http://mixxx.org > >> > >> > >> Mixxx-devel mailing list > >> Mixxx-devel@lists.sourceforge.net > <mailto:Mixxx-devel@lists.sourceforge.net> > >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > >> > > > > > > ------------------------------------------------------------------------------ > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > Mixxx-devel@lists.sourceforge.net > <mailto:Mixxx-devel@lists.sourceforge.net> > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > > > ------------------------------------------------------------------------------ > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > <mailto:Mixxx-devel@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
