* Trent Piepho on Friday, October 15, 2010 at 10:19:20 -0700
> On Fri, Oct 15, 2010 at 12:40 AM, Christian Ebert <[email protected]>wrote:
>
>> * Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700
>>> Looks like you didn't actually change the needed lines.
>>
>> No, I didn't but Bernhard did:
>> +
>> #if defined(__SSE2__)
>> int d = 0;
>> - __asm__ volatile("cpuid" : "=d"(d) : "a"(1) : "ebx", "ecx");
>> +/* __asm__ volatile("cpuid" : "=d"(d) : "a"(1) : "ebx", "ecx"); */
>> + __asm__ volatile("movl %%ebx, %1; cpuid; movl %1, %%ebx" : "=d"(d),
>> "=&g"(tmp) : "a"(1) : "ecx");
>> if ((d & (1 << 26))) {
>> mjpeg_info("SETTING SSE2 for standard
>> Temporal-Noise-Filter");
>> temporal_filter_planes = temporal_filter_planes_sse2;
>>
>
> The second cpuid call below this one needs to be fixed as well.
You're right of course; the error appeared for only one line as
well, should've noticed that.
With this change, yuvdenoise builds again, but someone in the
know should check whether I've broken other stuff:
Index: yuvdenoise/main.c
===================================================================
RCS file: /cvsroot/mjpeg/mjpeg_play/yuvdenoise/main.c,v
retrieving revision 1.71
diff -u -r1.71 main.c
--- yuvdenoise/main.c 14 Oct 2010 16:57:54 -0000 1.71
+++ yuvdenoise/main.c 15 Oct 2010 17:48:20 -0000
@@ -1336,7 +1336,8 @@
mjpeg_info("SETTING SSE2 for standard Temporal-Noise-Filter");
temporal_filter_planes = temporal_filter_planes_sse2;
- __asm__ volatile("cpuid" : "=d"(d) : "a"(0x80000001) : "ebx",
"ecx");
+/* __asm__ volatile("cpuid" : "=d"(d) : "a"(0x80000001) :
"ebx", "ecx");*/
+ __asm__ volatile("movl %%ebx, %1; cpuid; movl %1, %%ebx" :
"=d"(d) : "a"(0x80000001) : "ecx");
if ((d & (1 << 29))) {
/* x86_64 processor */
mjpeg_info("SETTING SSE2 for Median-Filter");
--
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Mjpeg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mjpeg-users
