Comment #12 on issue 178 by [email protected]: Revise API and impl
http://code.google.com/p/jss7/issues/detail?id=178
Sergey:
CAP:
- JDOCs with ASN are scrambled, <pre> or any other way to pre format
should be used!
- overall JDOCs missing. Since CAP is a mesh of TCAP, INAP and ISUP it
should be awesome to have JDOCs which explain for instance what
CalledPartyBCDNumber.getAddress() return in comparison to AddressString
which it extend
- Some interfaces use both wrapper and primitive type, for instance:
TimeIfTariffSwitch
- CAPNoticeProblemDiagnostic.getCode() is never used - other enum
- ServingCheckResult ^^
- CAPGeneralAbortReason ^^
- There is CAPErrorCode class which has ints for error conditions, this
class should either:
1. be part of ReturnError, so defs of code are there(not a good option)
2. become enum + ReturnError.getError() + ReturnError.getRawCode() for
cases enum is not there
- API allows
CAPErrorMessage.getEmParameterless().getEmParameterless().getEmParameterless()
woooohoo!!! all variables of CAPErrorMessage must not implement
CAPErrorMessage
- ChargeIndicatorValue.getCode not used
- BurstList has only on Burst ? Wrong interface names? This can be seen in
many places
- CallCompletionTreatmentIndicator.getCode not used
- CallingPartyRestrictionIndicator ^^
- CGEncountered ^^
- ChangeOfLocationAlt is empty ?
- ConferenceTreatmentIndicator.getCode not used
- ConnectedNumberTreatmentInd ^^
- ControlType ^^
- CwTreatmentIndicator ^^
- EctTreatmentIndicator ^^
- FCIBCCCAMELsequence1 - is this a typo ? Does it really have to end with
digit?
- HoldTreatmentIndicator.getCode not used
- FCIBCCCAMELsequence1SMS ? '1' ? I think there are few more classes like
this.
-
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
