Comment #13 on issue 178 by [email protected]: Revise API and impl
http://code.google.com/p/jss7/issues/detail?id=178
ALL:
- enum have inconsistent defs -> getCode vs getValue vs getIndicator vs
getAlgo vs getType
- enum have inconsistent defs -> return null vs throw IOException vs
other exception( should be illegal arg exception )
- enum have inconsistent defs -> small vs capital letters, etc
- enum have inconsistent defs - if there is String literal there is def of
it and than its doubled, for instance(iirc mostly in SCCP): OriginationType
CAP:
- enum getInstance should probably throw IllegalArgumentException in case
of wrong value, rather than return null, which will make throw nasty NPE
INAP:
- enum getInstance should probably throw IllegalArgumentException in case
of wrong value, rather than return null, which will make throw nasty NPE
- Both CAP and INAP jdocs have '&' character scattered in content,
probably some localization issue
- as in CAP some JDOCs are scrambled
- as in CAP, JDOCs are missing, if some class extends existing one, it
needs clarification on new methods, for instance
CalledPartyBCDNumber.getAddress() -> what does this method return in
comparison to AddressString methods? Also, it would seem that
CalledPartyBCDNumber doubles AddressString methods.
- CriticalityType.getCode not used
- EventTypeBCSM ^^
- TerminalType ^^
- CallCompletionTreatmentIndicator ^^
- CallDiversionTreatmentIndicator ^^
M3UA:
- enum getInstance and such, just like above, should probably throw
IllegalArgumentException
- State is interface, is there any reason to that? Why not enum ?
- MessageClass is interface, why not enum ?
- MessageType ^^
- CallingPartyRestrictionIndicator ^^
- CallOfferingTreatmentIndicator ^^
- CGEncountered ^^
- ConferenceTreatmentIndicator ^^
- ConnectedNumberTreatmentInd ^^
- Heartbeat/HeartbeatACK - typo in interface name, should have second
capital letter?
- ErrorCode return int, why not enum?
- Parameter is just interface with static values, yet, its extended by
other interfaces, this makes no sense, parameter codes are internal, no
need for all Parameters to have full set of codes!
- RegistrationStatus return int, why not enum ?
- Status ^^ ?
- TrafficModeType ^^ ?
- UserCause ^^
MTP:
- Mtp3StatusCause.getCode!
- Mtp3Primitive.type - why not enum?
SCCP:
- RemoteSccpStatus small letters ( yeah sounds silly )
- enum have different behavior in getInstance methods
- enums have different name for getXXXX method( getValue, getAlgo,
getIndicator) GlobalTitleIndicator, NatureOfAddress, NumberingPlan,
RoutingIndicator,...
- String literals are defined twice in enums, ie. LoadSharingAlgorithm
- all that GT stuff mentioned earlier.
- utils class looks like abandoned child
-
TCAP:
- AbortReason is empty
- JDOCs have '?' scattered in content
- enums have different getFromString/Int/Whatever
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
