Comment #14 on issue 178 by [email protected]: Revise API and impl
http://code.google.com/p/jss7/issues/detail?id=178
ALL:
- enums inconsitient defs - either variable like def or Word_Word_Word or
WordWordWord(definitions of values). In some cases enum start with
underscore.
-
- wrapper types are used along with primitive types. We should do use only
one. For instance in MAPErrorMessageCallBarred:
Boolean getUnauthorisedMessageOriginator();
long getMapProtocolVersion();
MAP:
- Possibly - MAPErrorMessagePositionMethodFailure extends MAPErrorMessage
- MAPErrorMessagePositionMethodFailure is subfield in MAPErrorMessage, by
no means the MAPErrorMessagePositionMethodFailure is not of MAPErrorMessage
type!( as quite few other classes!)
- MAPDialogueAS vs MAPDialog, lets stick either to GB english or to US
english
- MAPMessageType.privideRoamingNumber_Response , also
lowerUppercase_Uppercase - this is a bit inconsitient, either variable like
def or Word_Word_Word or WordWordWord. Other enums have WordWordWord def
type.
- Might not be a valid case for this fix, but... MAP has interfaces
like 'MAPErrorCode' - interfdace with static defs -> lowerWordWord -
usually static defs are all capital - or atleast they dont start with lower
case.
- Not sure if this is fixed already but MAPDialogListener is not
serializable, while MAPProvider is, this is wrong.
- MAPServiceBase ^^
- MAPServiceListener ^^
- MAPSmsTpduParameterFactory ^^
- NationalLanguageIdentifier.getCode for undefined value returns
Reserved(0)
- MAPAbortProviderReason.code - no getter, not used
- MAPAbortSource ^^
- MAPNoticeProblemDiagnostic ^^
- MAPRefuseReason ^^
- ServingCheckResult ^^
- ... many more ^^
- Time/AbsoluteTimeStamp interface probably could be improved( use enums
for day, month... ?)
- Long addInsertSubscriberDataRequest - any reason to return wrapper? This
sort of add/get/set methods are scattered all over place.
- MAPMessage use generics for MAPDialog type?
- TypeOfShape --> ShapeType ?
- TypeOfNumber ^^
- TeleserviceCode -> 's' should be capital?
- ExtTeleserviceCode ^^
- TeleserviceCodeValue ^^
- ZoneCode - indicates ASN as OCTET STRING, yet
byte[] getData();
int getValue();
- if NationalLanguageLockingShiftIdentifier is like
Gsm7NationalLanguageIdentifier there should be sub interface which declares
common part, by no means NationalLanguageLockingShiftIdentifier extends
Gsm7NationalLanguageIdentifier
- NationalLanguageSingleShiftIdentifier ^^
- UserData.encode/decode should not be publicly visible? Same for
getEncodedData ?
-
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
