I think we are pretty close. I don't think we have any outstanding strings at this point.
I have looked at many l10n bugs and resolved almost all of them. L10N related commits/changes: Fixes 1163117 - Copy for on-boarding <https://github.com/mozilla/firefox-ios/commit/cef4c9d6425d5371092fbeb95156c831009a7d72> Fixes 1172111 - Copy for remote tabs panel <https://github.com/mozilla/firefox-ios/commit/f428f44068300c3548195c9ae63432fe3c0505fd> Fixes 1168402 - Copy for Reading List empty-state <https://github.com/mozilla/firefox-ios/commit/70761d5711e43507dd787df8d5a6a659a5a0d55f> Fixes 1168400 - Copy for Send Tab extension empty state <https://github.com/mozilla/firefox-ios/commit/77bb893481ff28b8aeae2e3d946c11336aede32f> Fixes 1151995 - [l10n] Fix string consistency: "Tap to reload page" <https://github.com/mozilla/firefox-ios/commit/0144f25f83061bdb8ce417c873fb9ee88582224b> Fixes 1153333 - Missing notes for NSLocalizedString <https://github.com/mozilla/firefox-ios/commit/ad8108e68f367adbfbf911278c624c3dc90c276b> Fixes 1163151 - Firefox for iOS: verify usage of newslines in strings <https://github.com/mozilla/firefox-ios/commit/0f491a644b4b32a52ea170d1137b93caefe312dc> Fixes 1179863 - Copy for Send Tab not logged in state <https://github.com/mozilla/firefox-ios/commit/503894866f877d0155034797ee56cf20bf933ef2> Fixes 1175887 - Not all string tables are properly converted to .stri… <https://github.com/mozilla/firefox-ios/commit/6e7d3ee3567ad3b3fbcf29e07c267ec48ef54731> The last one is worth mentioning: a number of strings were not actually included in the build. I'm surprised nobody really noticed. I think that shows that we need to figure out a way to do more automated testing. For example with screenshots taken of every possible piece of UI that we have. S. On Tue, Jun 30, 2015 at 10:53 PM, Stefan Arentz <[email protected]> wrote: > As discussed last week in Whistler, we are aiming for L10N string freeze > by the end of this week. > > I have browsed through the app sources and I could not find any static > (non-NSLocalizedString) strings. Please prove me wrong. > > We do have a bunch of strings that need a quick review before they can be > localized in their final form: > > > https://bugzilla.mozilla.org/showdependencytree.cgi?id=1168395&hide_resolved=1 > > I'll hope to get those finalized on Thursday. > > My questions to you are: > > * If you know we are going to add new functionality with new strings in > the coming days/week, please add them as soon as possible. Or discuss so > that we can find a way to get them translated before the code lands. > > * If you know of more strings in the app that need review, please file a > bug and make it block 1168395. > > What did I miss? > > S. > >
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
