On 9-Jun-06, at 6:54 PM, Bob Ippolito wrote: > On Jun 9, 2006, at 6:15 PM, Beau Hartshorne wrote: > >> On 7-Jun-06, at 7:13 PM, Bob Ippolito wrote: >> >>> Base seems like a good enough place for it. Ignoring performance, >>> is backwards compatibility even an issue? I don't think it would >>> break anything to camelize everywhere appropriate. >> >> I don't really know. I replaced computedStyle entirely, and added a >> test for it. From what I understand, this could break old code that >> did something like computedStyle(elem, 'backgroundColor') instead of >> computedStyle(elem, 'background-color'). This isn't a big deal in >> MochiKit code because it never queries on properties longer than one >> word. >> >> I'd like to get more feedback on these changes. Here's the ticket: >> http://trac.mochikit.com/ticket/116 > > I don't see how it would change behavior, since camelize is going > to be a no-op for already camelized names... > > >>> camelize('backgroundColor') > "backgroundColor" > >>> camelize('background-color') > "backgroundColor"
The problem was that one branch in computedStyle expects hyphen case. We can convert the camel case to hyphen case in just that branch. The function should work either way now: http://trac.mochikit.com/changeset/932 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit -~----------~----~----~----~------~----~------~--~---
