Are you getting an error? Perhaps sending in the error regarding makeEventBean() would be better in this case than sending in a patch. Your patch isn't going to work because the CollectionBeanMaker is set up to handle typed structs for passing to remoting endpoints. In order for that to work, CollectionBeanMaker doesn't need a setter to inject a value from the collection into the target and your patch would break it.
So if you're getting an error, send in the error so we can figure out what's wrong. Otherwise a description of the problem you're having? Or another patch with the understanding that the CBM is set up to inject into structs (creating key names) or objects (calling setters). Also, if you're ending up with stray public properties on a CFC after calling makeEventBean() make sure your field list is actually accurate... if you're setting your field list explicitly you should only have that issue if you have an incorrect entry in your field list and the value of the stray property should always be an empty string. If the issue is something larger, try using MG's internal ColdSpring instance as a parent bean factory to your own CS instance and replacing modelglue.beanPopulator with an instance of BeanUtilsPopulator (note that this requires you go get Joe's BeanUtils library and make a /com/firemoss mapping). That will use BeanUtils to handle your bean population and, well, BeanUtils is cool... it traverses composite objects, passing things from the input collection into composed objects inside the passed-in object, among other things. At least I think I have that right... I haven't actually USED BeanUtils, but I've talked to Joe about it. What I do know is that your CollectionBeanMaker patch isn't going into the framework... thanks for submitting it though! As for your ReactorAdapter patch, I believe you're correct. I don't actually have commit permissions to the MG:G repo at the moment (JOE! heh), but I'll follow up to make sure Dan or Joe get this committed if our discussion proves it to be a valid patch. In any case, thanks for submitting patches at all... you're a shining example to the rest of the community. Gold star for your efforts! ;) Laterz, J On Oct 8, 2008, at 6:04 PM, denstar wrote: > > Assuming 111 is HEAD, I think that the makeEventBean for MG3 is > missing an if. > > Here's a patch (jira isn't up right now): > > Index: ModelGlue3/ModelGlue/Util/CollectionBeanMaker.cfc... > Index: ModelGlue3/ModelGlue/unity/orm/ReactorAdapter.cfc... --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "model-glue" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/model-glue?hl=en For more about Model-Glue, check http://www.model-glue.com . -~----------~----~----~----~------~----~------~--~---
