* Paul LeoNerd Evans <[EMAIL PROTECTED]> [2006-07-12 19:50]: > Before I go too much further, I'd appreciate hearing any > comments anyone has on it. In terms of the code, and in terms > of how I've packaged it up. I couldn't find much documentation > on how to submit a collection of .pm files, so I just tried > taring up the directory and uploading it, and that appeared to > work. :)
The code looks OK. The tests aren’t very good, but they’re better than some of my test suites, so that’s OK, too. The POD is jarring, though. Use uppercase section names, and stick to their common names. Curb your abuse of italics and lists-for-indentation. Use commata in the signature shown and lose the redundant `sub` bit. Describe your inputs/outputs in prose, this isn’t Javadoc. Also, there are neither README nor Changes files to help your human readers nor a META.yml to make work easier for the machines. I suggest you use Module::Starter::PBP to create a distribution skeleton, then fill that in. Regards, -- Aristotle Pagaltzis // <http://plasmasturm.org/>
