On Thu, 13 Jul 2006 03:01:50 +0200
"A. Pagaltzis" <[EMAIL PROTECTED]> wrote:

> The code looks OK. The tests aren’t very good, but they’re better
> than some of my test suites, so that’s OK, too.

OK. Well, I'd appreciate hearing any suggestions on more things to
test... I'm a big fan of getting the testing right, but often I can't
quite think of things to test. Usually I end up expanding test code on
account of bug reports. Though obviously it's better to know of issues
before they're reported as bugs. :)

> The POD is jarring, though. Use uppercase section names, and
> stick to their common names. Curb your abuse of italics and
> lists-for-indentation. Use commata in the signature shown and
> lose the redundant `sub` bit. Describe your inputs/outputs in
> prose, this isn’t Javadoc.

OK; have done all that. I think the docs look a bit better now - more
like other perl modules.

> Also, there are neither README nor Changes files to help your
> human readers nor a META.yml to make work easier for the
> machines.

Have added Changes and META.yml now.

I suspect it'll take me a few iterations before I get this one right...
Any more comments from anyone on new version 0.02?

-- 
Paul "LeoNerd" Evans

[EMAIL PROTECTED]
ICQ# 4135350       |  Registered Linux# 179460
http://www.leonerd.org.uk/

Attachment: signature.asc
Description: PGP signature

Reply via email to