Yeah, I think that closing of that ticket is right. As far as 
mongrel_rails is concerned, it makes sense to use the --clean option, 
rather than put it in there to happen by default. (although actually, 
I'd have --clean be default).

My problem is that I'm using mongrel_cluster_ctl instead of 
mongrel_rails. The nice feature of mongrel_cluster_ctl here is that you 
can give it a -c argument which is a directory containing mongrel 
cluster yml files. And it will do the invoked operation to ALL of those 
config files. I like this. I want to use it.

And mongrel_cluster_ctl's --clean option appears to be broken to me. I 
guess I should figure out how to fix it and submit a patch?

The other problem is that the sample script at 
resources/mongrel_cluster, which invokes mongrel_cluster_ctl, doesn't 
invoke the --clean option (which wouldn't work right even if it did, but 
once it does). So I guess I should fix that and submit a patch too? 

I'm new to submitting patches for this kind of stuff. Can anyone 
reccommend patch etiquette/procedure to do this properly? And/or confirm 
that I'm approaching this sanely?

Thanks for the help, all.

Jonathan

Simon Santoro wrote:
> On Wednesday 05 March 2008 17:59:49 Jonathan Rochkind wrote:
>   
>> What is the reccommended solution to this?
>>     
>
> I don't know, put there is a patch here:
> http://textsnippets.com/posts/show/931
> and a ticket got submitted here:
> http://rubyforge.org/tracker/index.php?func=detail&aid=11098&group_id=1306&atid=5147
>
> but it was not committed because "mongrel_rails now supports a --clean".
> my mongrel_rails does not support it, but I may have an old version.
>
> I think it would be right for mongrel to clean up it's stale pid files. Every 
> program I know of does that, and I patched my mongrel.
>
> _______________________________________________
> Mongrel-users mailing list
> Mongrel-users@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-users
>   

-- 
Jonathan Rochkind
Digital Services Software Engineer
The Sheridan Libraries
Johns Hopkins University
410.516.8886 
rochkind (at) jhu.edu

_______________________________________________
Mongrel-users mailing list
Mongrel-users@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-users

Reply via email to