The --clean feature, in my testing, seems to indeed checks to make sure that pid files really -are- stale (ie, the pid listed in there does not correspond to any running process) before deleting them.
I still don't understand why --clean isn't the default behavior though, but I guess the developer didn't like that for some reason. Seems to me documentation should recommend everyone always use --clean----especially in any automated scripts that will be run unattended! Jonathan John Joseph Bachir wrote: > On Wed, Mar 5, 2008 at 2:16 PM, Simon Santoro <[EMAIL PROTECTED]> wrote: > >> there is a patch here: >> http://textsnippets.com/posts/show/931 >> and a ticket got submitted here: >> >> http://rubyforge.org/tracker/index.php?func=detail&aid=11098&group_id=1306&atid=5147 >> >> but it was not committed because "mongrel_rails now supports a --clean". >> my mongrel_rails does not support it, but I may have an old version. >> >> I think it would be right for mongrel to clean up it's stale pid files. >> Every >> program I know of does that, and I patched my mongrel. >> > > > Furthermore, the behavior of the --clean feature isn't very > elaborately documented (at least not in the output of mongrel_rails > cluster::start -h). I left this comment on the ticket (no way to > reopen it I guess): > > ---- > The patch mentioned checks if the pid files refer to running processes. > > Does the --clean feature do this? Or does it just blindly remove the pid > files? > > An additionally nice and easy feature would be to check if the running > process contains the string "mongrel". > > > John > > -- Jonathan Rochkind Digital Services Software Engineer The Sheridan Libraries Johns Hopkins University 410.516.8886 rochkind (at) jhu.edu _______________________________________________ Mongrel-users mailing list Mongrel-users@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-users
