this.el = $type(el) === 'string' ? $(el) : el; can be just
this.el = $(el); Regards Rajeev J Sebastian On Sun, Oct 12, 2008 at 11:41 PM, SilverTab <[EMAIL PROTECTED]> wrote: > > Finally found a way to make git work on windows... > > repo is located here: http://github.com/SilverTab/hoverpick/tree/master > > > On Oct 12, 1:46 pm, SilverTab <[EMAIL PROTECTED]> wrote: >> Valid point indeed.... I'll make the change... >> >> I'll push it to my github eventually if I figure out how to make it >> work properly on windows... >> >> On Oct 12, 1:37 pm, "Guillermo Rauch" <[EMAIL PROTECTED]> wrote: >> >> > I wouldn't put the panels in the options hash. I'd make it an argument of >> > initialize.Then, when you extend (ie HoverPick.time), you override >> > initialize and remove that argument. >> >> > It makes more sense too, since it's not an "option". >> >> > On Sun, Oct 12, 2008 at 3:14 PM, SilverTab <[EMAIL PROTECTED]> wrote: >> >> > > Well, I'm pretty much done with HoverPick.Time but I'm not really >> > > satisfied with the code... pretty sure it could be done in a better >> > > way... anyway here it is (basically its just a small extension of >> > > HoverPick.base with new options. The only method that I've override is >> > > updateText() where the formatting is done...) >> >> > >http://www.silverscripting.com/MooTimePick/hoverpick.time.html >> >> > > If anyone wants to peek at the code and see how HoverPick.Time can be >> > > improved, I'll gladly accept any suggestions/ideas! :) >> >> > > On Oct 11, 9:18 pm, Tom Occhino <[EMAIL PROTECTED]> wrote: >> > > > Very nice progress SilverTab. You've taken a nice plugin and extracted >> > > > it into a simple generic base for lots of other useful plugins. >> >> > > > Good stuff >> >> > > > On Oct 11, 2008, at 6:16 PM, SilverTab wrote: >> >> > > > > Ok, I've rewritten the HoverPicker class completely... it can now >> > > > > work >> > > > > with any number of levels (panels)... and I've stripped anything that >> > > > > was unnecessary (result formatting, etc etc)... so right now it's not >> > > > > even time or date related, the basic stuff and events are there >> > > > > that's >> > > > > it.. >> >> > > > > You can see it in action here with 3 and 5 levels: >> > > > >http://www.silverscripting.com/MooTimePick/test.html >> >> > > > > Next, I'll start on the subclasses, HoverPicker.Time and >> > > > > HoverPicker.Date >> >> > > > > On Oct 11, 4:16 pm, SilverTab <[EMAIL PROTECTED]> wrote: >> > > > >> Quick Update: >> > > > >> I'm rewritting the base class (HoverPanel.Base) from scratch so that >> > > > >> it is much more generic and can work with any amount of "panels" ... >> > > > >> once this is done it will be pretty easy to subclass it and create >> > > > >> HoverPanel.Time and HoverPanel.Date... >> >> > > > >> I'll post my progress here... >> >> > > > >> On Oct 10, 5:47 pm, SilverTab <[EMAIL PROTECTED]> wrote: >> >> > > > >>> First, the latest edge build fixed the IE bug! So right now it's >> > > > >>> working well in IE, FF, Webkit and Opera.. (which is good news!) >> > > > >>> Now, Aaron, in reply to your post: >> >> > > > >>> 1) let me know when you're back, I will gladly accept any help I >> > > > >>> can >> > > > >>> get! :) >> >> > > > >>> 2) A good date class would definitely help, right now it's still a >> > > > >>> bit >> > > > >>> of a mess... >> >> > > > >>> 3) The latest build fixed the issue, but I will still keep >> > > > >>> Element.setPosition in mind >> >> > > > >>> 4) see 3) >> >> > > > >>> 5) That part is up to you guys! ;) >> >> > > > >>> -silvertab >> >> > > > >>> On Oct 10, 5:22 pm, nutron <[EMAIL PROTECTED]> wrote: >> >> > > > >>>> A couple of things: >> > > > >>>> 1) I'm about to go offline for a day or two, so I can't chip in, >> > > > >>>> but I'd >> > > > >>>> love to. I expect you'll have all this sorted out by the time I'm >> > > > >>>> back >> > > > >>>> though. >> >> > > > >>>> 2) You might look at Date.js in the Clientside repo. I haven't >> > > > >>>> looked at the >> > > > >>>> source code for this plugin yet, but it might be helpful to have >> > > > >>>> some easier >> > > > >>>> date methods. >> >> > > > >>>> 3) You might look at Element.setPosition in the Clientside repo, >> > > > >>>> as it >> > > > >>>> manages positioning for you (it positions one element relative to >> > > > >>>> another). >> > > > >>>> It works in all browsers. >> >> > > > >>>> 4) There WAS a bug in IE that we fixed that will be out next >> > > > >>>> week. You >> > > > >>>> could, for the time being, go snag that file out of the git repo >> > > > >>>> (just with >> > > > >>>> your web browser - you don't need git to download it) and include >> > > > >>>> it and see >> > > > >>>> if it fixes your problems. >> >> > > > >>>> 5) I'd still love to include this in the Clientside repo if it >> > > > >>>> doesn't go >> > > > >>>> into MooTools-more. >> >> > > > >>>> -a >> >> > > > >>>> On Fri, Oct 10, 2008 at 2:01 PM, tomocchino < >> > > > >>>> [EMAIL PROTECTED]<[EMAIL PROTECTED]> >> > > <ml-user >> > > > >>>> [EMAIL PROTECTED]> >> >> > > > >>>>> wrote: >> >> > > > >>>>> They should... but they probably dont :) >> >> > > > >>>>> try with the latest edge build... Aaron / Daniel added a fix for >> > > > >>>>> getOffsets... >> >> > > > >>>>> On Oct 10, 2008, at 4:41 PM, SilverTab wrote: >> >> > > > >>>>>> Ok, about the IE bug... is it possible that element.getPosition >> > > > >>>>>> and >> > > > >>>>>> element.getSize is yielding a different result in IE than in >> > > > >>>>>> FF?? It >> > > > >>>>>> shouldn't right?? This is the code I'm using to position the >> > > > >>>>>> main DIV >> > > > >>>>>> (keep in mind that "this.el" refers to the text input)... >> >> > > > >>>>>> this.mainDiv = new Element('div', { >> > > > >>>>>> 'styles' : { >> > > > >>>>>> 'position': 'absolute', >> > > > >>>>>> 'width': '100%', >> > > > >>>>>> 'left': this.el.getPosition().x, >> > > > >>>>>> 'top': this.el.getPosition().y + this.el.getSize().y >> > > > >>>>>> } >> > > > >>>>>> }); >> >> > > > >>>>>> It works fine in FF and Webkit, again, not in IE.... which >> > > > >>>>>> doesn't >> > > > >>>>>> make much sense if we consider that getPosition and getSize >> > > > >>>>>> should >> > > > >>>>>> return the same results in both browser??? >> >> > > > >>>>>> On Oct 10, 4:24 pm, SilverTab <[EMAIL PROTECTED]< >> > >http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1317758&i=0 >> >> > > > >>>>> wrote: >> > > > >>>>>>> Yeah obviously, it would be easier to use with a shorter date >> > > > >>>>>>> range... >> > > > >>>>>>> As far as seconds goes, well I already added it, but it >> > > > >>>>>>> resulted >> > > > >>>>>>> pretty much in clunkier code... >> >> > > > >>>>>>> I'm trying to think of a way to make it simple AND easy to >> > > > >>>>>>> extend, >> > > > >>>>>>> but >> > > > >>>>>>> it might not be as easy as I initially thought... >> >> > > > >>>>>>> I really don't mind sending the code to github or whatever if >> > > > >>>>>>> anyone >> > > > >>>>>>> wants to take a look at it and help me figure it out... >> > > > >>>>>>> problem is, I >> > > > >>>>>>> only used git on linux and right now I'm on windows so... I'll >> > > > >>>>>>> have >> > > > >>>>>>> to >> > > > >>>>>>> find a "git on windows" tutorial or something hehe... (and to >> > > > >>>>>>> think I >> > > > >>>>>>> was FINALLY getting used to svn haha).... >> >> > > > >>>>>>> On Oct 10, 4:17 pm, Tom Occhino <[EMAIL PROTECTED]< >> > >http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1317758&i=1 >> >> > > > >>>>> wrote: >> >> > > > >>>>>>>> In my last message when I said 'hours, minutes, seconds' i >> > > > >>>>>>>> meant >> > > > >>>>>>>> 'hours, minutes, am/pm'. If a user did decide they needed >> > > > >>>>>>>> seconds >> > > > >>>>>>>> as >> > > > >>>>>>>> well, maybe it could be made easy to extend the >> > > > >>>>>>>> HoverPicker.Time >> > > > >>>>>>>> Class >> > > > >>>>>>>> to add it, but it was just a typo on my part. >> >> > > > >>>>>>>> Anyway, decades sounds like a good way to do the year, but I >> > > > >>>>>>>> think >> > > > >>>>>>>> there should be some way to omit it, as in, only allow the >> > > > >>>>>>>> user to >> > > > >>>>>>>> pick month and day and have the year be assumed. I was >> > > > >>>>>>>> originally >> > > > >>>>>>>> thinking in terms of the 'Publish Article On:' date range >> > > > >>>>>>>> instead of >> > > > >>>>>>>> 'When were you born:' date range. >> >> > > > >>>>>>>> If I come up with any good ideas for the interface I'll let >> > > > >>>>>>>> you >> > > > >>>>>>>> know ;) >> >> > > > >>>>>>>> - Tom >> >> > > > >>>>>>>> On Oct 10, 2008, at 3:54 PM, SilverTab wrote: >> >> > > > >>>>>>>>> Been trying to fix the IE bug for a while with no luck... if >> > > > >>>>>>>>> anyone >> > > > >>>>>>>>> has a clue as to why the whole thing isn't positioned >> > > > >>>>>>>>> properly in >> > > > >>>>>>>>> IE >> > > > >>>>>>>>> (it should be like 20 or so pixels lower) please let me >> > > > >>>>>>>>> know ... >> >> > > > >>>>>>>>> Right now this is what it looks like: >> > > > >>>>>>>>> Text Element, Div (Positioned absolutely) > ul, ul, ul (all >> > > > >>>>>>>>> positioned absolutely) >> >> > > > >>>>>>>>> I tried the following: >> > > > >>>>>>>>> Text Element, Div (Positioned absolutely) > Div (Positioned >> > > > >>>>>>>>> relatively) > ul, ul, ul (all positioned absolutely) >> >> > > > >>>>>>>>> but no luck... :( >> >> > > > >>>>>>>>> On Oct 10, 2:40 pm, SilverTab <[EMAIL PROTECTED]< >> > >http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1317758&i=2 >> >> > > > >>>>> wrote: >> > > > >>>>>>>>>> Gotta agree that scrolling would make it so much cooler >> > > > >>>>>>>>>> hehe... >> >> > > > >>>>>>>>>> First thing first though, right now the code is very messy >> > > > >>>>>>>>>> (i.e. I >> > > > >>>>>>>>>> didn't code it with Time AND Date in mind so it's not very >> > > > >>>>>>>>>> "inheritance" friendly...) so the first step I guess would >> > > > >>>>>>>>>> be to >> > > > >>>>>>>>>> separate the methods/properties etc to determine if it >> > > > >>>>>>>>>> should be >> > > > >>>>>>>>>> part >> > > > >>>>>>>>>> of .Base, .Date or .Time.... Probably a bunch of methods >> > > > >>>>>>>>>> that >> > > > >>>>>>>>>> need to >> > > > >>>>>>>>>> be re-written with that in mind.... >> >> > > > >>>>>>>>>> And IE is still a problem :-( >> >> > > > >>>>>>>>>> On Oct 10, 2:34 pm, "Guillermo Rauch" <[EMAIL PROTECTED]< >> > >http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1317758&i=3 >> >> > > > >>>>> wrote: >> >> > > > >>>>>>>>>>> It's good, but scroll when the right and left boundaries >> > > > >>>>>>>>>>> are >> > > > >>>>>>>>>>> reached would >> > > > >>>>>>>>>>> be amazing too...For example when there're more than 10 >> > > > >>>>>>>>>>> elements, >> > > > >>>>>>>>>>> the rest >> >> ... >> >> read more ยป >
