Jeremie Courreges-Anglas <j...@wxcvbn.org> writes: > John Hood <cg...@glup.org> writes: > >> Thanks for the fix. I ended up fixing some problems with our test cases >> so that they run properly on OpenBSD 6.0+, and your change checks out >> OK. It's all at <https://github.com/mobile-shell/mosh/pull/862>. >> Keith, Jeremie, would you mind looking at that? > > With the pull request applied, I can run the test suite: 1 unexpected > failure. I did not investigate, please see log attached. > > re tmux -V: I would just return 0 if the OS is OpenBSD, no need for > release number tests. tmux was added to the base system for > OpenBSD-4.6, and capture-pane was added to tmux for OpenBSD-4.7. Those > releases are old and completely unsupported by the OpenBSD project. > > re locale charmap: a portable alternative could be > locale | grep ^LC_CTYPE | grep -qi utf-8 > > For mosh-1.3.0 I would suggest fixing the pledge call as a minimum. > I can easily handle the test suite patches locally until next release.
Just to make things clear: of course I could also patch the
pledge("ioctl") issue in the OpenBSD port. But then, users who compile
from upstream tarballs could still report this issue to the mosh
project.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
_______________________________________________ mosh-devel mailing list mosh-devel@mit.edu http://mailman.mit.edu/mailman/listinfo/mosh-devel
