On 03/21/2017 06:07, Jeremie Courreges-Anglas wrote: > John Hood <cg...@glup.org> writes: > >> Thanks for the fix. I ended up fixing some problems with our test cases >> so that they run properly on OpenBSD 6.0+, and your change checks out >> OK. It's all at <https://github.com/mobile-shell/mosh/pull/862>. >> Keith, Jeremie, would you mind looking at that? > With the pull request applied, I can run the test suite: 1 unexpected > failure. I did not investigate, please see log attached. The failure you encountered is not serious; it checks an edge case of Unicode handling that is rarely if ever seen in the real world, the test is fragile, and I suspect the failure is due to recent changes in tmux. > > re tmux -V: I would just return 0 if the OS is OpenBSD, no need for > release number tests. tmux was added to the base system for > OpenBSD-4.6, and capture-pane was added to tmux for OpenBSD-4.7. Those > releases are old and completely unsupported by the OpenBSD project. This seems reasonable, especially since Mosh also depends on more recent Perl versions anyway. > > re locale charmap: a portable alternative could be > locale | grep ^LC_CTYPE | grep -qi utf-8 I have another solution in the works-- a wrapper program for our is_utf8_locale() function. That's more accurate for our needs and avoids all the variation in locale(1) implementations. > > For mosh-1.3.0 I would suggest fixing the pledge call as a minimum. > I can easily handle the test suite patches locally until next release.
I agree that pulling only your fix is the right thing for mosh-1.3.0, and I've done so. Don't worry about bringing the other changes into the OpenBSD port right now; I will try and sort these issues out and check them into Mosh master. --jh _______________________________________________ mosh-devel mailing list mosh-devel@mit.edu http://mailman.mit.edu/mailman/listinfo/mosh-devel
