The function where this code lives doesn't exist anymore...
The problem is that we have to know at the same time: 1) tag/node info
(BDO) and 2) attribute (DIR). One place where those are available, is
nsPresContext::ResolveStyleContextFor, after style resolution. But then
2 additional includes are needed:
nsINameSpaceManager.h // for kNameSpaceID_HTML
nsHTMLAtoms.h // for nsHTMLAtoms::dir
Do you have other suggestions?
Thanks,
Lina
Steve Clark wrote:
>
> In nsHTMLSpanElement.cpp, this is no big deal but the code could be
> simplified a bit (and sped up ever so slightly):
>
> ...
> +
> +#ifdef IBMBIDI
> + // Instead, we could derive class nsHTMLBdoElement : public
> nsHTMLSpanElement
> + // But this would add more code...
> remove >+ nsCOMPtr<nsIAtom> tag;
> remove >+ GetTag(*getter_AddRefs(tag) );
> +
> change >+ if (mNodeInfo->Equals(nsHTMLAtoms::bdo))
> + aMapFunc = &MapBdoAttributesInto;
> + else
> +#endif // IBMBIDI
> aMapFunc = &MapAttributesInto;
> return NS_OK;
> }
>
