Steve Clark <[EMAIL PROTECTED]> wrote:
>
> From Akkana:
>
<snip>
>Most of the changes to nsPresShell.cpp are whitespace formatting
>changes, which in nearly every case take lines which previously lined
>up with the lines around them, and make them not line up. What's up
>with that? I don't own nsPresShell.cpp, so it's someone else's decision,
>but if it were a file I owned I'd veto all those whitespace changes.
>The code I was reviewing in DoCopy was hard to read because of
>incorrect indentation (I ended up reformatting my local copy).
>I'd at least like to see that part formatted, and the other
>reformatting changes inside DoCopy removed.
I've backed out the formatting changes, but I wouldn't be surprised if
I've introduced others. nsPresShell.cpp is full of TAB characters,
which makes its whitespacing inherently unstable. Should one report a
bug on something like this?
<snip>
>Doesn't this assume that it's always going in the reverse direction,
>without checking? I don't really know how bidi works, but it
>doesn't seem consistent with what he does earlier in visual mode.
No, this is correct. The code earlier allows for the text mode of the
*source* to be either visual left-to-right or visual right-to-left, so
when copying from visual right-to-left source to logical clipboard it
doesn't need to reverse the text. However there is no visual
right-to-left mode for the *clipboard*, so copying from logical source
to visual clipboard there will always be a reverse.
I've made the other changes you suggest.
Simon
