There's a few problems in 3.34 that needs to be fixed... ;)
1. In get_audio.c the new wav/aiff routines presume that u_short etc are
pre-typedef'ed without even including sys/types.h.
2. In l3bitstream.c line 90 the following is done;
if ( frameResults == NULL )
{
frameResults = (BF_FrameData*) calloc( 1, sizeof(*frameData) );
assert( frameData );
}
this must be wrong (a quick cut'n'paste job? ;) ), I presume;
if ( frameResults == NULL )
{
frameResults = (BF_FrameResults*) calloc( 1, sizeof(*frameResults) );
assert( frameResults );
}
is the correct way. ;)
3. No biggie, but;
masking_lower = pow(10,masking_lower_db/10);
at line 655 in quantize.c should prolly be;
masking_lower = pow(10.0,masking_lower_db/10.0);
to prevent unecessary conversions...
4. Also #define inline should prolly be a Makefile define (instead of adding
all kinds of systems at line 20 in takehiro.c), as more systems than MSV_C
use a different inline code...
- CISC
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
