MoiN
On Fri, Feb 04, 2000 at 07:54:19PM +0100, Cavallo de Cavallis wrote:
> > > oh one stupid suggestion for the stand alone executable : it could be a good
> > > idea to allow "| more" or "/page" or "> file.asc" to see the command help,
> > > now it "goes away" without seein the beginning of it
>
> >Learn your shell; the output is going to stderr, not stdout. You're only
> >redirecting stdout. (If/when telling LAME to send it's output to stdout,
> >you'd then collide with the usage outout and never see it).
>
> I know my shell, it cant handle that, so i suggested to modify lame on win32based
> system. btw i suggested it to see the command help so when no params are passed
According to the GNU coding standards, a program should have the
option "--help" to "output brief documentation for how to invoke
the program, on standard output, then exit successfully."[1] I
suggest to change lame to use this option.
If you call lame without any arguments, this is considered an
error, so lame should display only a brief message which points
the user to the "--help" option.
I have modified the latest CVS version to print a few lines to
stderr if called with no arguments and to print the usage to
stdout if called with "--help". Thus I had to modify
display_bitrates() to take an argument which filehandle to use. I
have also added the option "--help" to the usage. The last change
I did was stop the option processing when an unrecognized gnu-style
option was found.
I have attached my changes as diff, if you want to have a look at
them.
Ingo
[1] http://www.gnu.org/prep/standards_14.html#SEC14
--
Not bad but bad enough...
lame.diff.gz
