************************************************************************
*** WARNING -- WARNING -- WARNING -- WARNING -- WARNING -- WARNING ***
************************************************************************
*
* The e-mail-message appended below is list- or mailserver-related
*
* That type of mail will by definition not be processed on this system
* and in general is not accepted in the fidonet.org-domain.
*
* To avoid these bouncings the listkeeper is kindly requested to
* remove any subscription coming from a z2.fidonet.org-style address.
*
* If you have reason to believe your message was removed without due
* reason then kindly inform '[EMAIL PROTECTED]'.
*
************************************************************************
From: Robert Hegemann @2:292/862
To: Sergey Sapelin @2:5020/1844.33
Subj.: Re: [MP3 ENCODER] lame/CODING_STYLE
Dated: 01 Sep 00 11:24:59
[processed here: 05 Sep 00 14:12:42]
@TOPT 33
@INTL 2:5020/1844 2:292/862
@MSGID: bob d7c10f8b
@REPLY: fuchs.offl.uni-jena.de fe567c04
@REPLYADDR: [EMAIL PROTECTED]
@REPLYTO: 2:292/862@fidonet UUCP
@PID: KMail [version 1.0.29.2]
@CHRS: LATIN-1 2
@RFC-Received: from geek.rcc.se ([EMAIL PROTECTED] [193.15.234.212]) by
infomag.iguana.be (8.9.3/8.9.3) with ESMTP id CAA01846 for
<[EMAIL PROTECTED]>; Sat, 2 Sep 2000 02:14:03 +0200
@RFC-Received: (from majordom@localhost) by geek.rcc.se (8.8.4/8.7.3) id
LAA30449 for mp3encoder-list; Fri, 1 Sep 2000 11:38:54 +0200
@RFC-X-Authentication-Warning: geek.rcc.se: majordom set sender to
[EMAIL PROTECTED] using -f
@RFC-Received: from mail.gmx.net (pop.gmx.net [194.221.183.20]) by geek.rcc.se
(8.8.4/8.7.3) with SMTP id LAA30445 for <[EMAIL PROTECTED]>; Fri, 1 Sep
2000 11:38:47 +0200
@RFC-Received: (qmail 13202 invoked by uid 0); 1 Sep 2000 09:42:27 -0000
@RFC-Received: from pec-66-32.tnt4.me.uunet.de (HELO bob) (149.225.66.32) by
mail.gmx.net with SMTP; 1 Sep 2000 09:42:27 -0000
@RFC-Content-Type: text/plain
@RFC-References: <[EMAIL PROTECTED]>
@RFC-In-Reply-To: <[EMAIL PROTECTED]>
@RFC-MIME-Version: 1.0
@RFC-Message-Id: <00090111374302.00422@bob>
@RFC-Content-Transfer-Encoding: quoted-printable
@RFC-Sender: [EMAIL PROTECTED]
From: Robert Hegemann <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Reply-To: [EMAIL PROTECTED]
Frank Klemm schrieb am Fre, 01 Sep 2000:
> lame/CODING_STYLE, version 0.001 ;-)
> ---------------------------------------------------------------------
> This is the first try of a Coding Style:
notes on some points
> * Don't use tabulators (the character with the value '\t') in source code,
> especially these with a width of unequal 8. Lame sources are using
> different sizes for tabulators.
I don't like tabulators too
> * Functions should be not longer than 50 lines of code.
this is debateable
> Every function should only do ONE thing, and this should
> be done well.
every proggi thinks his functions are doing well, until he finds
out the flaws he introduced.
> * Document functions.
programmers don't document, you know ;-)
OK, your point is clear and I'll try to add more comments
(hopefully useful remarks..)
> * Don't use single 'short' variables to save storage.
> Short variables are especially on Pentium Class Computer much slower than
> int's. DEC alpha also hates short variables.
>
> Example: float bla [1024];
> short i;
> for ( i = 0; i < 1024; i++ )
> bla [i] = i;
I'm not so sure about shorts. Documents on the Intel compiler suggest
for example to put the index variables of nested loops in a struct
to improve cache performance, this way they would be in the same cache line.
Ciao Robert
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
@Via ifmail 2:292/862@fidonet, Sat Sep 2 2000 at 02:14 (2.14-tx8.10)
@Via D'Bridge 1.58 2:292/854 09/05 14:04
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
