Hi,
First, the bad news. Werner, the MuseScore lead developer, is currently
working on staff type. He is adding the possibility to change the type of a
staff along the time axis. It means your changes and his changes will need
to be merged.
Regarding StaffType, we used to have a hierarchy for the first
implementation but Werner changed it to a single class because he saw no
benefit. We don't have a lot of staff type object around and it's a small
optimization. So I'm not sure it's very valuable to do that now You can
probably add to StaffType for now and we can see how we can split later.
Regarding note and rest, we have a lot more of them and it would make more
sense to have a hierarchy here. However, we choose to have information
about fret etc... in a note, even in a standard staff, because it makes it
easier to change from a standard staff to a tablature staff and keep these
information. Still I feel it's a good idea and a possible optimisation, so
it's fine to make JianpuNote and JianpuRest helpers, or even derive from
Note/Rest.
Could you make a pull request with your current code? I will mark it work
in progress and so Werner and I can follow your progress closer.
Thanks!
lasconic
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mscore-developer
