Hi, On Thu, 24 Jan 2008, Kirill wrote:
> I've just pushed two patches to mob: > - minor modifications to build with VS2005; Your commit messages are not easily readable for me, since they extend well over the 76 characters that I can read with the 4-space indent of "git log". Please fix. Also, you mention that gcc behaves more like VS2005 when two options are used; why not add them to the Makefile in the same commit? Also, reading the patch, I see that we had "char * name" before; I do not like that coding style. I'd rather use the same coding style as in git.git, i.e. "char *name". > - ability to install for the current user only. I see that you have at least one hard coded path in there: +"PathToMsys"="c:\\download\\msysgit" That's not good. Please imitate what you find in the Makefile, and provide an "install-user" target as well as an "install-user.reg.in" instead of "install-user.reg". In general, I think the git development style would be a good procedure to follow; post patches here for review, if needed, adjust the patches, and repost. That makes it easier to come up with a patch that is better than whatever single developer could have written. Likewise, don't be afraid of criticising me when you think that I am doing something wrong. As long as you have technical arguments to back that up, I am eager to listen. So, if you find code in git-cheetah that you find worthy of improvement, bring it on. > It did not work with the remote.mob.url, you provided, failing with an > error: fatal: '/git-cheetah.git': unable to chdir or not a git > archive. So, I took the Push URL from http://repo.or.cz/w/git-cheetah.git. > Hopefully, I did not break anything. Oh, sorry. I was wrong: the push URL has an extra "/srv/git"... Ciao, Dscho
