Hi,

On Thu, 24 Jan 2008, Kirill wrote:

> On Jan 24, 2008 9:55 AM, Johannes Schindelin 
> <[EMAIL PROTECTED]> wrote:
>
> > On Thu, 24 Jan 2008, Kirill wrote:
> >
> > > - ability to install for the current user only.
> >
> > I see that you have at least one hard coded path in there:
> >
> > +"PathToMsys"="c:\\download\\msysgit"
> >
> > That's not good.  Please imitate what you find in the Makefile, and 
> > provide an "install-user" target as well as an "install-user.reg.in" 
> > instead of "install-user.reg".
>
> Fixed in the following patches. However, how about removing those two 
> keys from .reg all together? We can rewrite DllRegisterServer to
>
> - create [HKEY_CLASSES_ROOT\CLSID\
> {ca586c80-7c84-4b88-8537-726724df6929}\InProcServer32] with the result
> of GetModuleFileName;

Certainly.

> - create [HKEY_CURRENT_USER\SOFTWARE\Git-Cheetah], following the same
> path as qgit to find git.exe.

I do not know what qgit does.  Care to explain?

> On Jan 24, 2008 12:56 PM, Johannes Schindelin
> <[EMAIL PROTECTED]> wrote:
>
> > Well, since I do not consider "push to mob" to be something like 
> > "publish", it is not too late at all to amend that commit.  Here's 
> > how:
>
> It worked beautifully on my local master branch. Now should I hope that 
> you'll do the magic with the remote mob branch [after the patches 
> review]?

Yes, I will do!

Ciao,
Dscho

Reply via email to