On May 4, 2008, at 11:09 PM, Johannes Sixt wrote:

On Sunday 04 May 2008 15:56, Steffen Prohaska wrote:
Hello,
Eventually, I succeeded in building a msys-1.0.dll with a tweaked
msys_p2w().  The result is on work/p2w (9ff65cc3d) in msysgit.
The commit message contains more details:

http://repo.or.cz/w/msysgit.git?a=commitdiff;h=9ff65cc3d

What do you think?  Should we use the modified msys-1.0.dll?

Thanks a lot!

But if I understand your patch correctly, it only caters for :/ at the
beginning and :: in the middle of a path-lookalike.

Yes.  I first tried to switch of the path list conversion completely.
But this did not work because it broke PATH.  Apparently msys_p2w()
is required to convert PATH from MSYS to Windows.


But I have some
repositories set up like this:

  [remote "origin"]
        url = R:/jsixt/something.git

and after a 'git pull' I see this in the commit message:

  Merge branch master of 'R;C:\GIT\jsixt/something.git'

because 'git pull' passes the configured url to git-fmt-merge-msg, at which
point bash mangles the path.

Maybe it's possible to remove a bit more of this dwimmery?

Absolutely.   Whoever has know breakages caused by path mangling
should send them and I'll figure out how to tweak msys_p2w().
Maybe we can add some test cases?

        Steffen

Reply via email to