On May 6, 2008, at 7:12 AM, Steffen Prohaska wrote:


On May 5, 2008, at 8:51 PM, Johannes Sixt wrote:

On Monday 05 May 2008 07:30, Steffen Prohaska wrote:
On May 4, 2008, at 11:09 PM, Johannes Sixt wrote:
and after a 'git pull' I see this in the commit message:

Merge branch master of 'R;C:\GIT\jsixt/something.git'

because 'git pull' passes the configured url to git-fmt-merge-msg,
at which
point bash mangles the path.

Absolutely.   Whoever has know breakages caused by path mangling
should send them and I'll figure out how to tweak msys_p2w().

I think this particular problem would be mitigated if msys_p2w() does nothing if the string contains characters that cannot be in a path, notably \r, \n,
\t.

Good idea.

But it does not fix your example.


I also plan to check if the part before the first colon (":") starts
with "." or "/".  msys_p2w() currently verifies this only for the
path after the first colon.

This ideas solves your example.

I pushed an updated msys.dll to work/p2w (50c0dc50).

        Steffen

Reply via email to