I was thinking about the id'ed FileSet's. Here is what would need changing:
* Add an Id property to the FileSet class * Add a collection of FileSet's to the Project class * Change how a FileSet initializes by doing what it currently does OR by specifying an Id. If the id is given, look up the FileSet in the Project's collection of FileSets. * Provide a FileSetTask that adds FileSet's to the Project's collection. On the surface it *seems* pretty easy. If it works out we could use the same strategy for other reusable collections (ie, Tomas's OptionSet). I encourage you do think about solving your problem this way rather than the comma seperated include pattern. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On > Behalf Of Kevin Dente > Sent: Sun, June 23, 2002 6:12 PM > To: Gerry Shaw; 'Nant developer's list' > Subject: RE: [nant-dev] FileSet includes question > > > Yeah, I kinda figured that out while reviewing the Ant > docs. :) > > The reason I say it make be useful is that it allows > non-trivial FileSets to be specified through property expansion. > > You see, I'm working on replacing a fairly complex > build system (built using NMake) with NAnt. The > original system let you create a very simple make file > (on the order of a few lines), and an included > "master" makefile contained as much of the build logic > as possible. For a build system with dozens of > projects, that makes it a lot easier to control things > without having to edit a ton of invididual make files > when you need to make a change. > > NAnt lets me do a lot with the include task, but there > currently isn't really a clean way to include a fileset > defined elsewhere (at least, not one with more than a single > include spec). By allowing a comma-delimited list of > patterns, a complex fileset could be passed around as a property. > > I understand the clarity issues that such a change > would introduces, though. A similar thing could be > accomplished (although not quite as richly) using > ids/refids, as I asked about it my other e-mail. > > --- Gerry Shaw <[EMAIL PROTECTED]> wrote: > > The docs are wrong. I shamelessly compied from > > directly from Ant :) and > > I must have missed that. > > > > I'm not sure it adds anything that you could already > > do with multiple > > <include> tags. I perfer things to be really > > obvious at the expense of > > more typing since you only have type stuff once but > > it will be read many > > times. > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > > > [mailto:[EMAIL PROTECTED]] > > On > > > Behalf Of Kevin Dente > > > Sent: Thu, June 20, 2002 11:31 AM > > > To: Nant developer's list > > > Subject: [nant-dev] FileSet includes question > > > > > > > > > The (now out of date) Nant documentation on the > > > sourceforge site for the FileSet says the > > following > > > about the includes element: > > > > > > "comma-separated list of patterns of files that > > must > > > be included" > > > > > > I read this to mean that a single <include> tag > > can > > > have multiple, comma-separated files/patterns in a > > > single includes element, ala <includes > > name="file1, > > > file2, file3". However, it doesn't appear that the > > > code works that way. Am I misinterpreting the > > docs? > > > Are the docs wrong? Is it intended to work that > > way, > > > but just doesn't yet? > > > > > > FWIW, I think it would be a nice feature. > > > > > > __________________________________________________ > > > Do You Yahoo!? > > > Yahoo! - Official partner of 2002 FIFA World Cup > > > http://fifaworldcup.yahoo.com > > > > > > > > > > > > > > > ------------------------------------------------------- > > > Sponsored by: > > > ThinkGeek at http://www.ThinkGeek.com/ > > > _______________________________________________ > > > Nant-developers mailing list > > [EMAIL PROTECTED] > > > > > > https://lists.sourceforge.net/lists/listinfo/nant-developers > > > > > > > > > > > > ------------------------------------------------------- > > Sponsored by: > > ThinkGeek at http://www.ThinkGeek.com/ > > _______________________________________________ > > Nant-developers mailing list [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/nant-developers > > > __________________________________________________ > Do You Yahoo!? > Yahoo! - Official partner of 2002 FIFA World Cup > http://fifaworldcup.yahoo.com > > > > ------------------------------------------------------- > Sponsored by: > ThinkGeek at http://www.ThinkGeek.com/ > _______________________________________________ > Nant-developers mailing list [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers > ------------------------------------------------------- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ _______________________________________________ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
