Thanks,

here is patch again, this time it is agains 0.85 RC3. I'd really love to see
this incorporated in core. There are some implementation problems which we
already discussed, though:

- what should happen, if referenced fileset have another basedir ?
- what should happen, if exclude/include of 2 filesets conflicts ?
- is every possible combination of those covered in test cases?

For mine use, I dont combine basedirs and dont use excludes at all, but
those problems should be solved. I feel, this is main problem why this
extension wasnt incorporated yet. Maybe we could discuss it now...


Martin Aliger
 

> -----Original Message-----
> From: Rory Becker [mailto:[EMAIL PROTECTED] 
> Sent: Friday, August 26, 2005 10:50 AM
> To: Martin Aliger
> Subject: Re: [nant-dev] Fwd: Filesets referencing filesets ?
> 
> Assuming that your syntax has not varied too greatly from the 
> version I saw in the newsgroup, I agree entirely that this is 
> the right way to go.
> 
> 
> No task supports more that one fileset but allowing a fileset 
> to contain or be created based on other filesets allows for 
> many combinations
> 
> I assume that this allows the derivative fileset types like 
> zipfileset to inherit a similar behaviour
> 
> I believe that this would make a great enhancement to the 
> core nant system.
> 
> How would we proceed from here
> 
> Can I get a copy of this patch?
> How would I use it?
> Should I wait for the community to approve the patch?(really 
> don't want to do this)
> 
> Ideas? Suggestions ?
> 
> Rory
> 
> BTW
>      Well done martin for this Idea / Implementation.  Very 
> simple and very powerful.
> 
> :)
> 
> On 8/26/05, Martin Aliger <[EMAIL PROTECTED]> wrote:
> > Hello Rory,
> > 
> > Currently, I fear, there is no such feature in NAnt. Some 
> tasks allow 
> > to specify multiple filesets, but only some...
> > 
> > That syntax you "stole" from another post was mine proposal 
> to extend 
> > current fileset task. I have it locally and it works for 
> me. I use it 
> > in production, in fact. I already sent patch for this and 
> could send 
> > more current one, if community have interest for it. I'd 
> like to see 
> > that incorporated in NAnt's core.
> > 
> > btw: it also allow adding to existing fileset - and its 
> what I need in 
> > production.
> > 
> > Martin Aliger
> > 
> > 
> > > -----Original Message-----
> > > From: [EMAIL PROTECTED]
> > > [mailto:[EMAIL PROTECTED] On Behalf Of 
> > > Rory Becker
> > > Sent: Thursday, August 25, 2005 1:59 PM
> > > To: nant-developers@lists.sourceforge.net
> > > Subject: [nant-dev] Fwd: Filesets referencing filesets ?
> > >
> > > This was posted to the users group originally
> > >
> > > sorry :)
> > >
> > > Rory
> > >
> > > ---------- Forwarded message ----------
> > > From: Rory Becker <[EMAIL PROTECTED]>
> > > Date: Aug 25, 2005 12:48 PM
> > > Subject: Filesets referencing filesets ?
> > > To: nantList <nant-users@lists.sourceforge.net>
> > >
> > >
> > > I would like to alter fileset so that it could reference multiple 
> > > other filesets but I am not sure where to start.
> > >
> > > The syntax has been stolen from a post I read 
> > > http://www.mail-archive.com/[EMAIL PROTECTED]
> > > net/msg03232.html
> > >
> > > and is as follows
> > >
> > > <fileset id="Group1">
> > >       <include name="File1.dll" />
> > >       <include name="File2.dll" />
> > > </fileset>
> > > <fileset id="Group2">
> > >       <include name="File3.dll" />
> > >       <include name="File4.dll" />
> > > </fileset>
> > > <fileset>
> > >       <includeFileset refid="Group1" />
> > >       <includeFileset refid="Group2" /> </fileset>
> > >
> > > I have found the fileset Class in Nant.Core and I figured 
> I needed 
> > > to determine how to use the refid syntax.
> > >
> > > So I looked for another class that already does this.
> > >
> > > The CopyTask seems to provide this but I cannot find 
> anything in the 
> > > source to indicate how this is handled.
> > >
> > > Can anyone help?
> > >
> > > Thanks
> > >
> > > Rory
> > >
> > >
> > > -------------------------------------------------------
> > > SF.Net email is Sponsored by the Better Software 
> Conference & EXPO 
> > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle 
> > > Practices Agile & Plan-Driven Development * Managing Projects & 
> > > Teams * Testing & QA Security * Process Improvement & 
> Measurement * 
> > > http://www.sqe.com/bsce5sf 
> > > _______________________________________________
> > > nant-developers mailing list
> > > nant-developers@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/nant-developers
> > >
> > 
> >
> 

Attachment: FileSet.cs.patch
Description: Binary data

Reply via email to