On 8/26/05, Martin Aliger <[EMAIL PROTECTED]> wrote: > Thanks, > > here is patch again, this time it is agains 0.85 RC3. I'd really love to see > this incorporated in core. There are some implementation problems which we > already discussed, though: > > - what should happen, if referenced fileset have another basedir ? > - what should happen, if exclude/include of 2 filesets conflicts ? > - is every possible combination of those covered in test cases? > > For mine use, I dont combine basedirs and dont use excludes at all, but > those problems should be solved. I feel, this is main problem why this > extension wasnt incorporated yet. Maybe we could discuss it now...
My take on the matter... I would definitely like the ability to combine filesets, personally... it places less onus on the task creator to add explicit support to reference files in different locations. I think that it is critical to support merging filesets with different basedirs, given this is probably the most requested feature for some tasks, such as the <zip> task - create a zip including files from different folders... the path to the file from the basedir is very important when determining the retained path in the zip. Regarding includes/excludes conflicts, I think it would make the most sense (ie- least support queries) to offer both: Logical intersection of two filesets - include all files referenced in each fileset, regardless if that file is excluded by the other fileset: <fileset> <include fileset="fileset1"/> <include fileset="fileset2"/> </fileset> Logical subtraction of two filesets - include those files in fileset1 that are not in fileset2: <fileset> <include fileset="fileset1"/> <exclude fileset="fileset2"/> </fileset> I'm not convinced it makes sense to include logical intersection of two filesets. Regarding determining "hits" between the contents of filesets for subtraction, I would suggest comparison based on path to the file relative to the containing fileset's basedir... so the file /a/b/c/d with a basedir of /a/b and the file /x/y/z/c/d with a basedir of /x/y/z would have the same relative path. Comments? Do other people's (expected?) usage patterns of filesets match/conflict with the above? -- Troy ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
